Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add antipatterns to circuit breaker documentation page #1621

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented Sep 22, 2023

The issue or feature being addressed

Details on the issue fix or feature implementation

  • I've migrated the V7 example codes to V8
  • I've extended the circuit-breaker.md with patterns and anti-patterns section

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

NOTE

In case of Pattern 3 I did not use the mdsnippets intentionally since it would require us to refer to Microsoft.Extensions.Http.Polly package. So, I inlined that code fragment instead.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (29ef55b) 84.63% compared to head (70f69d5) 84.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files         306      306           
  Lines        6820     6820           
  Branches     1044     1044           
=======================================
  Hits         5772     5772           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.63% <ø> (ø)
macos 84.63% <ø> (ø)
windows 84.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/strategies/circuit-breaker.md Show resolved Hide resolved
docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/circuit-breaker.md Show resolved Hide resolved
docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/circuit-breaker.md Outdated Show resolved Hide resolved
docs/strategies/circuit-breaker.md Show resolved Hide resolved
docs/strategies/circuit-breaker.md Show resolved Hide resolved
docs/strategies/circuit-breaker.md Show resolved Hide resolved
@peter-csala peter-csala changed the title Add antipatterns to circuit breaker documentation page [DOCS] Add antipatterns to circuit breaker documentation page Sep 22, 2023
@peter-csala peter-csala changed the title [DOCS] Add antipatterns to circuit breaker documentation page [Docs] Add antipatterns to circuit breaker documentation page Sep 22, 2023
@martintmk martintmk merged commit 7144f68 into App-vNext:main Sep 22, 2023
18 checks passed
@martincostello martincostello added documentation v8 Issues related to the new version 8 of the Polly library. labels Sep 26, 2023
@martincostello martincostello added this to the v8.0.0 milestone Sep 26, 2023
@peter-csala peter-csala deleted the add-antipatterns-to-circuit-breaker-strategy branch October 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants