Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide from v7 to v8 #1598

Merged
merged 20 commits into from
Sep 19, 2023
Merged

Migration guide from v7 to v8 #1598

merged 20 commits into from
Sep 19, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Sep 19, 2023

Details on the issue fix or feature implementation

Migration guide from v7 to v8

Contributes to #1091

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Sep 19, 2023
@martintmk martintmk added this to the v8.0.0 milestone Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (73a0848) 83.99% compared to head (65b2b5f) 83.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1598   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files         280      280           
  Lines        6548     6548           
  Branches     1020     1020           
=======================================
  Hits         5500     5500           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
macos 83.99% <ø> (ø)
windows 83.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adamnova adamnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes mostly, but I can see some of the migrations being harder to navigate with so many options and nothing particularly matching one option to another.

src/Snippets/Docs/Migration.Bulkhead.cs Show resolved Hide resolved
src/Snippets/Docs/Migration.Retry.cs Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved

<!-- snippet: migration-policy-wrap-v8 -->
```cs
// The "PolicyWrap" is integrated directly. Strategies are executed in the same order as they were added:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the comment I think is the best for understanding the changes. If I just look at the code sample, it's enough to understand what has changed from it directly and easily.

docs/migration-v8.md Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
@martintmk martintmk enabled auto-merge (squash) September 19, 2023 11:22
@martintmk martintmk merged commit 1bdaf86 into main Sep 19, 2023
14 checks passed
@martintmk martintmk deleted the mtomka/docs-migration branch September 19, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants