Finalize the API review #1528
Merged
Finalize the API review #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
- Coverage 84.02% 83.98% -0.05%
==========================================
Files 278 278
Lines 6546 6542 -4
Branches 1024 1023 -1
==========================================
- Hits 5500 5494 -6
- Misses 837 839 +2
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
Aug 30, 2023
Comment on lines
88
to
89
| /// The generator can override the delay generated by the retry strategy. If generator returns <see langword="null"/>, the delay generated | ||
| /// by retry strategy for that attempt will be used. |
There was a problem hiding this comment.
Suggested change
| /// The generator can override the delay generated by the retry strategy. If generator returns <see langword="null"/>, the delay generated | |
| /// by retry strategy for that attempt will be used. | |
| /// The generator can override the delay generated by the retry strategy. If the generator returns <see langword="null"/>, the delay generated | |
| /// by the retry strategy for that attempt will be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Outcome.FromResultAsTasktoOutcome.FromResultAsValueTaskto indicateValueTaskis returned.RetryDelayGeneratorArguments.DelayHint. Now, returning nullTimeSpanhas the same effect as using delay hint.PredicateResult.TrueandPredicateResult.Falseare now methods.Outcome.EnsureSucccesstoOutcome.ThrowIfExceptionBrokenCircuitException<TResult>back toPolly. Polly V8 only throwsBrokenCircuitException. (solves problems with disposable results)Closes #1507
Closes #1301
This change finalizes the API review and allows us to publish the beta.
Confirm the following