Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Outcome internals and drop unused hedging and fallbacks APIs #1523

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 29, 2023

Details on the issue fix or feature implementation

Internal changes only.

  • Drop non-generic APIs for fallback and hedging as there are not used nor exposed
  • Simplify some hedging and fallback internals
  • Cleanup Outcome<> struct.
    • The unsafe conversion between types moved to BridgeComponent as it is the only consumer
    • Conversion to and from Object-based outcomes dropped as it's no longer necessaary.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 29, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 29, 2023
@martintmk martintmk enabled auto-merge (squash) August 29, 2023 09:35
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1523 (37318c4) into main (94db492) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
- Coverage   84.11%   84.00%   -0.12%     
==========================================
  Files         278      278              
  Lines        6586     6540      -46     
  Branches     1026     1023       -3     
==========================================
- Hits         5540     5494      -46     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux 84.00% <100.00%> (-0.12%) ⬇️
macos 84.00% <100.00%> (-0.12%) ⬇️
windows 84.00% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rcuitBreakerResiliencePipelineBuilderExtensions.cs 100.00% <ø> (ø)
...Core/CircuitBreaker/CircuitBreakerStateProvider.cs 100.00% <ø> (ø)
...ack/FallbackResiliencePipelineBuilderExtensions.cs 100.00% <ø> (ø)
src/Polly.Core/Outcome.TResult.cs 100.00% <ø> (ø)
src/Polly.Core/Outcome.cs 100.00% <ø> (ø)
src/Polly.Core/Utils/TaskHelper.cs 100.00% <ø> (ø)
...CircuitBreaker/CircuitBreakerResilienceStrategy.cs 100.00% <100.00%> (ø)
...ircuitBreaker/Controller/CircuitStateController.cs 100.00% <100.00%> (ø)
src/Polly.Core/Fallback/FallbackHandler.cs 100.00% <100.00%> (ø)
.../Polly.Core/Fallback/FallbackResilienceStrategy.cs 100.00% <100.00%> (ø)
... and 6 more

@martintmk martintmk enabled auto-merge (squash) August 29, 2023 10:13
@martintmk martintmk merged commit dd511b2 into main Aug 29, 2023
15 of 16 checks passed
@martintmk martintmk deleted the mtomka/cleanup-internals branch August 29, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants