API Review Feedback

[martintmk]

Details on the issue fix or feature implementation

• Drop ResilienceContext.ResilienceEvents
• Rename ResiliencePipeline.Null to ResiliencePipeline.Empty
• Hide some Outcome<> properties
• Drop RateLimiterRejected.RetryAfter

Contributes to #1233

Confirm the following

• I started this PR by branching from the head of the default branch
• I have targeted the PR to merge into the default branch
• I have included unit tests for the issue/feature
• I have successfully run a local build

[martincostello]

At this point I'm finding #1233 too unwieldly to follow so I've stopped keeping up to date with it.

How many more changes are we expecting before we actually freeze the public API unless there's specific user feedback in an issue?

[codecov]

Codecov Report

Merging #1506 (e82c984) into main (69e5f16) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   83.91%   83.86%   -0.06%     
==========================================
  Files         273      272       -1     
  Lines        6503     6481      -22     
  Branches     1026     1020       -6     
==========================================
- Hits         5457     5435      -22     
  Misses        837      837              
  Partials      209      209              

Flag	Coverage Δ
linux	?
macos	83.86% <100.00%> (?)
windows	83.86% <100.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...Core/Hedging/Controller/HedgingExecutionContext.cs	100.00% <ø> (ø)
src/Polly.Core/ResilienceContext.cs	100.00% <ø> (ø)
...olly.Core/Telemetry/ResilienceStrategyTelemetry.cs	100.00% <ø> (ø)
...lly.RateLimiting/OnRateLimiterRejectedArguments.cs	100.00% <ø> (ø)
src/Polly.Core/Outcome.TResult.cs	100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipeline.cs	100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipelineBuilderBase.cs	100.00% <100.00%> (ø)
src/Polly.Core/ResiliencePipelineT.cs	100.00% <100.00%> (ø)
src/Polly.Core/Utils/Pipeline/PipelineComponent.cs	100.00% <100.00%> (ø)
...olly.Extensions/Telemetry/TelemetryListenerImpl.cs	100.00% <100.00%> (ø)
... and 1 more

[martintmk]

At this point I'm finding #1233 too unwieldly to follow so I've stopped keeping up to date with it.

How many more changes are we expecting before we actually freeze the public API unless there's specific user feedback in an issue?

Hopefully not too many. We are trying to wrap the API by the end of the month. It's mostly about hiding/dropping some stuff and polishing the surface.

Just thinking, would opening a new PR with something like Polly V8: Public API Review (final polish) actually help?

[martincostello]

Just thinking, would opening a new PR with something like Polly V8: Public API Review (final polish) actually help?

Possibly.

The main problem I have is that the diff is massive so looking for inline comments when I've marked a file as reviewed is difficult, and there's so many comments on the PR that most of them are hidden if they're old:

[martintmk]

Just thinking, would opening a new PR with something like Polly V8: Public API Review (final polish) actually help?

Possibly.

The main problem I have is that the diff is massive so looking for inline comments when I've marked a file as reviewed is difficult, and there's so many comments on the PR that most of them are hidden if they're old:

Let me give a shot at this tomorrow. There are maybe 10 comments left to address. Some of these came just recently, however it might be good to have something where one is not immediately lost :)