Introduce NonReactiveResilienceStrategy
#1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public abstract class NonReactiveResilienceStrategy | ||
| { | ||
| /// <summary> | ||
| /// An implementation of non-reactive resilience strategy that executes the specified <paramref name="callback"/>. |
There was a problem hiding this comment.
Suggested change
| /// An implementation of non-reactive resilience strategy that executes the specified <paramref name="callback"/>. | |
| /// An implementation of a non-reactive resilience strategy that executes the specified <paramref name="callback"/>. |
martincostello
approved these changes
Aug 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #1476 +/- ##
==========================================
+ Coverage 83.90% 83.92% +0.02%
==========================================
Files 275 276 +1
Lines 6498 6508 +10
Branches 1015 1016 +1
==========================================
+ Hits 5452 5462 +10
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
The follow-up of #1462 that introduces the base class for non-reactive resilience strategies.
Additional changes:
ResilienceStrategyinternal (similar toResilienceStrategy<T>). We now have full control over these top-level types.This change make the decision when implementing a new resilience strategy straightforward:
NonReactiveResilienceStrategywhen you want to implement non-reactive strategy.ReactiveResilienceStrategy<T>when you want to implement reactive strategy.Confirm the following