Improve usability of ResilienceStrategy<T> #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
Jul 25, 2023
| /// <typeparam name="TState">The type of state associated with the callback.</typeparam> | ||
| /// <param name="callback">The user-provided callback.</param> | ||
| /// <param name="context">The context associated with the callback.</param> | ||
| /// <param name="state">The state associated with the callback.</param> | ||
| /// <returns>The instance of <see cref="ValueTask"/> that represents the asynchronous execution.</returns> | ||
| /// <exception cref="ArgumentNullException">Thrown when <paramref name="callback"/> or <paramref name="context"/> is <see langword="null"/>.</exception> | ||
| public ValueTask<TResult> ExecuteAsync<TState>( | ||
| Func<ResilienceContext, TState, ValueTask<TResult>> callback, | ||
| public ValueTask<T> ExecuteAsync<T, TState>( |
There was a problem hiding this comment.
I wonder if there's a better name we can give this rather than T?
There was a problem hiding this comment.
Maybe just swap T with TResult?
So it will be ResilienceStrategy<T> but individual methods will have TResult?
There was a problem hiding this comment.
I didn't have any good suggestions - your one sounds fine to me.
Codecov Report
@@ Coverage Diff @@
## main #1428 +/- ##
=======================================
Coverage 83.92% 83.92%
=======================================
Files 275 275
Lines 6526 6526
Branches 1007 1007
=======================================
Hits 5477 5477
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
These changes enable flowing the type used in the callback back to the result:
Previously, these all would be object:
Confirm the following