Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce allocations in telemetry #1321

Merged
merged 5 commits into from
Jun 19, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 19, 2023

Details on the issue fix or feature implementation

Closes #1312

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 19, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 19, 2023
@martintmk martintmk changed the title Improve perf Reduce allocations in telemetry Jun 19, 2023
@martintmk martintmk force-pushed the mtomka/improve-telemetry-perf branch from cb6c880 to 0893253 Compare June 19, 2023 09:53
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1321 (56880f5) into main (ce97ea5) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
+ Coverage   83.37%   83.49%   +0.11%     
==========================================
  Files         268      269       +1     
  Lines        6335     6379      +44     
  Branches     1001     1004       +3     
==========================================
+ Hits         5282     5326      +44     
  Misses        844      844              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.49% <100.00%> (+0.11%) ⬆️
windows 83.49% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Polly.Extensions/Telemetry/EnrichmentUtil.cs 100.00% <ø> (ø)
...olly.Core/Telemetry/ResilienceStrategyTelemetry.cs 100.00% <100.00%> (ø)
...lly.Core/Telemetry/TelemetryEventArguments.Pool.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Telemetry/TelemetryEventArguments.cs 100.00% <100.00%> (ø)
src/Polly.Core/Utils/ObjectPool.cs 100.00% <100.00%> (ø)
...lly.Extensions/Telemetry/EnrichmentContext.Pool.cs 100.00% <100.00%> (ø)
...rc/Polly.Extensions/Telemetry/EnrichmentContext.cs 100.00% <100.00%> (ø)
...s/Telemetry/ResilienceTelemetryDiagnosticSource.cs 100.00% <100.00%> (ø)
...xtensions/Telemetry/TelemetryResilienceStrategy.cs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@martintmk martintmk enabled auto-merge (squash) June 19, 2023 10:18
@martintmk martintmk merged commit b73f456 into main Jun 19, 2023
9 checks passed
@martintmk martintmk deleted the mtomka/improve-telemetry-perf branch June 19, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reduce allocations in telemetry
2 participants