Fix SA1108 and SA1118 (#2148)

Remove SA1108 and SA1118 from `NoWarn` list.
App-vNext · Jun 7, 2024 · deb5087 · deb5087
1 parent 7b971f5
commit deb5087
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Polly/Polly.csproj b/src/Polly/Polly.csproj
@@ -9,7 +9,7 @@
  <IncludePollyUsings>true</IncludePollyUsings>
  <NoWarn>$(NoWarn);CA1010;CA1031;CA1032;CA1033;CA1051;CA1062;CA1063;CA1064;CA1068;CA1710;CA1716;CA1724;CA1805;CA1815;CA1816;CA2211</NoWarn>
  <NoWarn>$(NoWarn);S2223;S3215;S3246;S3971;S4039;S4049;S4457</NoWarn>
- <NoWarn>$(NoWarn);SA1108;SA1118;SA1414</NoWarn>
+ <NoWarn>$(NoWarn);SA1414</NoWarn>
  <!--Public API Analyzers: We do not need to fix these as it would break compatibility with released Polly versions-->
  <NoWarn>$(NoWarn);RS0037;</NoWarn>
  </PropertyGroup>

diff --git a/src/Polly/Timeout/TimeoutEngine.cs b/src/Polly/Timeout/TimeoutEngine.cs
@@ -46,8 +46,9 @@ internal static class TimeoutEngine
  */
  actionTask.Wait(timeoutCancellationTokenSource.Token);
  }
- catch (AggregateException ex) when (ex.InnerExceptions.Count == 1) // Issue #270. Unwrap extra AggregateException caused by the way pessimistic timeout policy for synchronous executions is necessarily constructed.
+ catch (AggregateException ex) when (ex.InnerExceptions.Count == 1)
  {
+ // Issue #270. Unwrap extra AggregateException caused by the way pessimistic timeout policy for synchronous executions is necessarily constructed.
  ExceptionDispatchInfo.Capture(ex.InnerException).Throw();
  }