Fix package validation (#2138)

- Fix the package validation job not failing if there are any issues.
- Move configuration of deterministic builds to MSBuild, rather than setting it from Cake, as this appears to have stopped working with the .NET 8.0.300 SDK.

.github/workflows/build.yml

@@ -157,6 +157,7 @@ jobs:
  }
  if ($invalidPackages -gt 0) {
  Write-Output "::error::$invalidPackages NuGet package(s) failed validation."
+ exit 1
  }
 
  sign:
@@ -246,6 +247,7 @@ jobs:
  }
  if ($invalidPackages -gt 0) {
  Write-Output "::error::$invalidPackages NuGet package(s) failed validation."
+ exit 1
  }
 
  - name: Checkout vcsjones/AuthenticodeLint

Directory.Build.props

@@ -2,4 +2,8 @@
  <PropertyGroup>
  <UseArtifactsOutput>true</UseArtifactsOutput>
  </PropertyGroup>
+ <PropertyGroup Condition=" '$(CI)' == 'true' ">
+ <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+ <Deterministic>true</Deterministic>
+ </PropertyGroup>
 </Project>

build.cake

@@ -114,9 +114,6 @@ Task("__BuildSolutions")
  },
  };
 
- dotNetBuildSettings.MSBuildSettings.Properties["ContinuousIntegrationBuild"] = [Environment.GetEnvironmentVariable("CI") ?? "false"];
- dotNetBuildSettings.MSBuildSettings.Properties["Deterministic"] = ["true"];
-
  DotNetBuild(solution.ToString(), dotNetBuildSettings);
  }
 });