Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/idx as fun #96

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Refactor/idx as fun #96

merged 2 commits into from
Oct 6, 2022

Conversation

leissa
Copy link
Member

@leissa leissa commented Oct 5, 2022

.Idx is now a constant of type .Nat -> *.

Unfortunately, the prec-magic in the output is pretty broken. For this reason, I needed to port a lot of tests from (.Idx 123) to .Idx 123.

Rmark: We should really fix the prec magic before adding more and more test cases Oo
(see #97)

@leissa
Copy link
Member Author

leissa commented Oct 5, 2022

Maybe this fixes #95

@leissa
Copy link
Member Author

leissa commented Oct 5, 2022

I also finally refactored:

  • type_int_ -> type_int
  • lit_int_ -> lit_int

So, I hope you have ported your branches in the meantime :)

@NeuralCoder3
Copy link
Collaborator

I needed to port a lot of tests from (.Idx 123) to .Idx 123.

This seems odd. Additional parentheses should not make a program invalid.
Especially since these parentheses are usually needed in other contexts in thorin (as opposed to other functional languages (Haskell, coq, OCaml, ...) where they are commonly omitted).

@leissa
Copy link
Member Author

leissa commented Oct 5, 2022

I needed to port a lot of tests from (.Idx 123) to .Idx 123.

This seems odd. Additional parentheses should not make a program invalid. Especially since these parentheses are usually needed in other contexts in thorin (as opposed to other functional languages (Haskell, coq, OCaml, ...) where they are commonly omitted).

No, I needed to port the CHECK-DAG part not the actual test case.

Copy link
Collaborator

@NeuralCoder3 NeuralCoder3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@leissa leissa merged commit de409cc into master Oct 6, 2022
@leissa leissa deleted the refactor/idx_as_fun branch October 6, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants