Avoid DeprecationWarning #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working. Preserves Python 2 compatibility.
hugovk
approved these changes
Jul 24, 2018
|
I don't think that's necessary. It's obvious from git blame and also easy to try. |
|
@Anorov Is there a schedule for the next release? It would be really nice to have this out. Thank you! |
|
In the meantime, here's how to install the latest dev version: pip install -U git+https://github.com/Anorov/PySocksOr with the latest commit: pip install -U git+https://github.com/Anorov/PySocks@b687a3402aaad60716c8d343bdfd091aaec705c3 |
|
I ran into this issue today. Would be nice to see a release to avoid having to add workarounds. |
jaraco
added a commit
to jaraco/jaraco.pmxbot
that referenced
this pull request
Jan 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working.
Preserves Python 2 compatibility.