Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Detekt and fix project errors #108

Merged
merged 9 commits into from
Dec 23, 2022
Merged

Add Detekt and fix project errors #108

merged 9 commits into from
Dec 23, 2022

Conversation

crocsandcoffee
Copy link
Member

@crocsandcoffee crocsandcoffee commented Dec 20, 2022 •
edited
Loading

📑 What does this PR do?

  • Fix issue: [FEAT]: Add Detekt & Lint checker to project #11
  • Majority of files that have changed are just the license header being updated so that it doesn't violate the max line rule which is 120 chars. (files with 9 lines changed)
  • Other changes:
  1. Fixing composable param orders from twitter rules
  2. Added an optimization for composables that take in List. I creates a new ImmutableListWrapper and added documentation

✅ Checklist

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

  • What is remaining to be implemented in this PR? Mention a list of them

🖼️ Screenshots (if applicable):

@crocsandcoffee crocsandcoffee self-assigned this Dec 20, 2022
digitalbuddha
digitalbuddha reviewed Dec 21, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@crocsandcoffee
Merge branch 'main' into detekt
8f78153 
 Conflicts:
	build.gradle.kts
	gradle/libs.versions.toml
	ui/signed-out/src/androidMain/kotlin/social/androiddev/signedout/selectserver/redirectScheme.kt
	ui/signed-out/src/androidMain/kotlin/social/androiddev/signedout/signin/SignInWebView.kt
	ui/signed-out/src/commonMain/kotlin/social/androiddev/signedout/selectserver/SelectServerContent.kt
	ui/signed-out/src/desktopMain/kotlin/social/androiddev/signedout/signin/SignInWebView.kt
	ui/timeline/src/commonMain/kotlin/social/androiddev/timeline/TimelineContent.kt
@crocsandcoffee
Merge branch 'detekt' of github.com:crocsandcoffee/MastodonCompose in…
c5ac2a2 
…to detekt
@crocsandcoffee
from review
f2d40da
@crocsandcoffee
fix new detekt errors
f43453d
@crocsandcoffee crocsandcoffee merged commit ead10bd into AndroidDev-social:main Dec 23, 2022
@crocsandcoffee crocsandcoffee deleted the detekt branch December 23, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evant evant evant left review comments

@digitalbuddha digitalbuddha digitalbuddha left review comments

@thebino thebino Awaiting requested review from thebino thebino is a code owner

Assignees

@crocsandcoffee crocsandcoffee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crocsandcoffee @evant @digitalbuddha