Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test summary behavior change with 6.15.0 release #762

Closed
chenrui333 opened this issue Aug 4, 2024 · 5 comments
Closed

test summary behavior change with 6.15.0 release #762

chenrui333 opened this issue Aug 4, 2024 · 5 comments

Comments

@chenrui333
Copy link

👋 looks like 6.15.0 release has test summary behavior change as below (0 failed part got removed somehow and extra ) in the summary report)

- 2 requests processed (2 succeeded, 0 failed)
+ 2 requests processed (2 succeeded))

is that expected? Thankss!

relates to Homebrew/homebrew-core#179991

@AnWeber
Copy link
Owner

AnWeber commented Aug 5, 2024

Yes was expected. I added better skipped and Errorerd Handling to cli. The summary got bloated. Now I only show the actual result status. I would recommend using Exit Code to get failed cli result. Is there a problem with the behavior?

@chenrui333
Copy link
Author

it has two )) in the end, which seems a bit off, wdyt?

@AnWeber
Copy link
Owner

AnWeber commented Aug 10, 2024

Ops. Yeah typo

AnWeber added a commit that referenced this issue Aug 17, 2024
@AnWeber
Copy link
Owner

AnWeber commented Aug 17, 2024

thx

@AnWeber AnWeber closed this as completed Aug 17, 2024
@chenrui333
Copy link
Author

chenrui333 commented Aug 23, 2024

np, I saw it fixed now :)

gonna ship via Homebrew/homebrew-core#182073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants