Revert "AK: Remove virtual destructors from non-virtual classes"

This reverts commit 4378d36.
AmusedNetwork · Apr 23, 2021 · f90c224 · f90c224
1 parent bf9c04a
commit f90c224
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/AK/IntrusiveRedBlackTree.h b/AK/IntrusiveRedBlackTree.h
@@ -17,7 +17,7 @@ template<Integral K, typename V, IntrusiveRedBlackTreeNode<K> V::*member>
 class IntrusiveRedBlackTree : public BaseRedBlackTree<K> {
 public:
  IntrusiveRedBlackTree() = default;
- ~IntrusiveRedBlackTree()
+ virtual ~IntrusiveRedBlackTree() override
  {
  clear();
  }

diff --git a/AK/RedBlackTree.h b/AK/RedBlackTree.h
@@ -33,10 +33,12 @@ class BaseRedBlackTree {
  : key(key)
  {
  }
+ virtual ~Node() {};
  };
 
 protected:
  BaseRedBlackTree() = default; // These are protected to ensure no one instantiates the leaky base red black tree directly
+ virtual ~BaseRedBlackTree() {};
 
  void rotate_left(Node* subtree_root)
  {
@@ -416,7 +418,7 @@ template<Integral K, typename V>
 class RedBlackTree : public BaseRedBlackTree<K> {
 public:
  RedBlackTree() = default;
- ~RedBlackTree()
+ virtual ~RedBlackTree() override
  {
  clear();
  }