Skip to content

Commit

Permalink
LibC: Implement crappy version of pread()
Browse files Browse the repository at this point in the history
This patch adds a crappy pread() just to get "git" working locally.
A proper version would be implemented in the kernel so that we don't
have to mess with the file descriptor's offset at all.
  • Loading branch information
awesomekling committed Feb 20, 2020
1 parent 7c12d66 commit cd49578
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
10 changes: 10 additions & 0 deletions Libraries/LibC/unistd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,16 @@ int unveil(const char* path, const char* permissions)
__RETURN_WITH_ERRNO(rc, rc, -1);
}

ssize_t pread(int fd, void* buf, size_t count, off_t offset)
{
// FIXME: This is not thread safe and should be implemented in the kernel instead.
off_t old_offset = lseek(fd, 0, SEEK_CUR);
lseek(fd, offset, SEEK_SET);
ssize_t nread = read(fd, buf, count);
lseek(fd, old_offset, SEEK_SET);
return nread;
}

char* getpass(const char* prompt)
{
dbg() << "FIXME: getpass(\"" << prompt << "\")";
Expand Down
1 change: 1 addition & 0 deletions Libraries/LibC/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ int setgid(gid_t);
pid_t tcgetpgrp(int fd);
int tcsetpgrp(int fd, pid_t pgid);
ssize_t read(int fd, void* buf, size_t count);
ssize_t pread(int fd, void* buf, size_t count, off_t);
ssize_t write(int fd, const void* buf, size_t count);
int close(int fd);
int chdir(const char* path);
Expand Down

0 comments on commit cd49578

Please sign in to comment.