Skip to content

Commit

Permalink
Meta: Add allow-list for icon size detection in CMake
Browse files Browse the repository at this point in the history
The only icons we are currently warning about are designed
and rendered as small icons intentionally, as their only use
is in desktop applets, and thus are exempt to this rule.

This reduces build spam back down to a minimum.
I should have just done this in the first place, back in SerenityOS#4729
  • Loading branch information
bgianfo authored and awesomekling committed Apr 20, 2021
1 parent 955eef8 commit c195ee6
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion Meta/CMake/utils.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,13 @@ function(serenity_app target_name)
if (EXISTS "${medium_icon}")
embed_resource("${target_name}" serenity_icon_m "${medium_icon}")
else()
message(WARNING "Missing medium app icon: ${medium_icon}")
# These icons are designed small only for use in applets, and thus are exempt.
list(APPEND allowed_missing_medium_icons "audio-volume-high")
list(APPEND allowed_missing_medium_icons "edit-copy")

if (NOT ${SERENITY_APP_ICON} IN_LIST allowed_missing_medium_icons)
message(WARNING "Missing medium app icon: ${medium_icon}")
endif()
endif()
endfunction()

Expand Down

0 comments on commit c195ee6

Please sign in to comment.