Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments uploaded by reporters have no created_by value #1350

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

4c0n
Copy link
Contributor

@4c0n 4c0n commented Aug 23, 2023

Description

The current data migration logic is incorrect. I assumed that the created_by value would be the email address of the reporters, but it turns out that is not the case.

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on main and is up to date with main
  • Check that the PR targets main
  • There are no merge conflicts and no conflicting Django migrations

@4c0n 4c0n merged commit 40730e1 into main Aug 23, 2023
7 checks passed
@4c0n 4c0n deleted the fix/incorrect-data-migration-logic branch August 23, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant