Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display history about externals #1340

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

4c0n
Copy link
Contributor

@4c0n 4c0n commented Aug 15, 2023

Description

Currently a reporter can see the communication with external parties in the "my signals" signal history.
This is undesirable and this PR makes sure that no longer happens.

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on main and is up to date with main
  • Check that the PR targets main
  • There are no merge conflicts and no conflicting Django migrations

How has this been tested?

  • Provided unit tests that will prove the change/fix works as intended
  • Tested the change/fix locally and all unit tests still pass
  • Code coverage is at least 85% (the higher the better)
  • No iSort, Flake8 and SPDX issues are present in the code

…external feedback received

(and that should not be displayed in the "my signals" history)
@4c0n 4c0n merged commit 66b74b5 into main Aug 15, 2023
7 checks passed
@4c0n 4c0n deleted the bug/do-not-display-information-about-externals branch August 15, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant