Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWL-10295: hub page minimal footer styleguide. #1519

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

alexmartinez92
Copy link
Contributor

Ticket(s)

Do not submit a Pull Request without a relevant JIRA ticket or Github issue! If you are creating a new pattern or feature, create an issue describing the need for this feature in Github first and then link to it below.

Github Issue

Jira Ticket

Description

Add styleguide component for Hub Page Footer.

To Test

  • clear caches
  • Navigate to Organismas > Footer > hub page footer, confirm footer displays according to the following Zeplins:
  • Desktop
  • Tablet
  • Mobile
  • Navigate to Pages > Hub page and confirm the styling is the same as in the above zeplins

Visual Regressions

Please provide the pull request ID below. This will then reference the automated VRT report after it has been generated.

A report is available here.

Before proceeding: Run visual regression tests locally to ensure new work does not introduce new bugs.

The visual regression tests always compare against the production version of the style guide. Changes and new work will show up as test failures. Please describe your work so that the report can be reviewed by the team.

If you are creating or updating a pattern be sure you have created or updated the scenario in backstop.json.

_After changes in the report are documented and demonstrate your desired changes, please mark the pull request as ready for review.

For more information on visual regression testing review the How do I run tests? document in Confluence.

Relevant Screenshots/GIFs

Use something like Skitch or GIPHY Capture to capture images/gifs to demonstrate behaviors.

Remaining Tasks

Things relevant to here may be updating The Glossary with the latest naming changes or review of the relative D8 work.

Additional Notes

Anything more to add? Good things to call out here are:

  • are there any PRs in this or other repositories that relate to or affect this PR?
  • are there any caveats or oddities testers should know about when testing this PR?
  • are there any problems you ran into during your work that you'd like to call out?

Guidelines for Contribution
SG2 Standards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants