EWL-10295: hub page minimal footer styleguide. #1519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
Do not submit a Pull Request without a relevant JIRA ticket or Github issue! If you are creating a new pattern or feature, create an issue describing the need for this feature in Github first and then link to it below.
Github Issue
Jira Ticket
Description
Add styleguide component for Hub Page Footer.
To Test
Visual Regressions
Please provide the pull request ID below. This will then reference the automated VRT report after it has been generated.
A report is available here.
Before proceeding: Run visual regression tests locally to ensure new work does not introduce new bugs.
The visual regression tests always compare against the production version of the style guide. Changes and new work will show up as test failures. Please describe your work so that the report can be reviewed by the team.
If you are creating or updating a pattern be sure you have created or updated the scenario in
backstop.json
._After changes in the report are documented and demonstrate your desired changes, please mark the pull request as
ready for review
.For more information on visual regression testing review the How do I run tests? document in Confluence.
Relevant Screenshots/GIFs
Use something like Skitch or GIPHY Capture to capture images/gifs to demonstrate behaviors.
Remaining Tasks
Things relevant to here may be updating The Glossary with the latest naming changes or review of the relative D8 work.
Additional Notes
Anything more to add? Good things to call out here are:
Guidelines for Contribution
SG2 Standards