Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change suggestions #1

Merged
merged 2 commits into from
May 4, 2018
Merged

change suggestions #1

merged 2 commits into from
May 4, 2018

Conversation

laurakn
Copy link
Collaborator

@laurakn laurakn commented May 4, 2018

Hi Amanda,

I wanted to work on my python skills before I headed out to that internship, so I figured I would do that by working on understanding and cleaning up the COMPAS code. Feel free to accept or reject any changes.

A couple maybe useful changes are there are three methods of choosing how to index the data, so we can look at it with different splits more easily. I also have it so you can just add and remove predictive features at the beginning, cleaned up some of the longer functions and used the logistic regression package.

Everything is a pandas df throughout, so it's easy to compare what the raw and debiased data looks like if one wanted to. I've also used column names instead of positions so it's maybe a little easier to follow.

If the paper is accepted, we should work on making it look super nice and add a link so others check out your analysis!

Great job on putting it all together in such a short time!

Best,

Laura

@Amandarg Amandarg merged commit 489f428 into Amandarg:master May 4, 2018
@Amandarg
Copy link
Owner

Amandarg commented May 4, 2018

Hey Laura,

Thanks! I think all the changes you made are super helpful, especially adding/removing predictive features and just cleaning it up in general. And yes, I agree we can work on making it super nice if it gets accepted. =)

Amanda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants