{ci} Clean up golangci job #602
Conversation
asmaloney
commented
Nov 25, 2022
- use macOS for runner to avoid extra updating/downloading
- use the go.mod file to determine go version
- use macOS for runner to avoid extra updating/downloading - use the go.mod file to determine go version
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
======================================
Coverage 2.95% 2.95%
======================================
Files 35 35
Lines 3282 3282
======================================
Hits 97 97
Misses 3184 3184
Partials 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| name: lint | ||
| runs-on: ubuntu-latest | ||
| name: Lint | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
@asmaloney may I ask why did you changed it to mac? Imo Ubuntu is faster
There was a problem hiding this comment.
I don't see that speed matter much here since the main build takes over 10 minutes (and I didn't notice much difference), but the Linux one was running an update and pulling down a bunch of packages. This is a waste of bandwidth and also means that it needs to be kept up-to-date if the required packages change.
Less required maintenance is good!
There was a problem hiding this comment.
Oh, you're right! Looks fair to me, thank you