Style setter: separate Push() and Pop() methods #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is intened to be used in AllenDang#533 for setting main CSS tag on MasterWindow (see AllenDang#533) but this is a separated change that could be useful not depending on CSS stuff This change allows to call styleSetter.Push/Pop as a normal, imgui-designed methods rather than using them as giu-styled widget.
af3a506
to
61b0c3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
=========================================
- Coverage 3.07% 3.07% -0.01%
=========================================
Files 32 32
Lines 3150 3155 +5
=========================================
Hits 97 97
- Misses 3052 3057 +5
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@AllenDang could you please merge |
gucio321
added a commit
to gucio321/giu
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is intened to be used in #533 for setting main CSS tag on MasterWindow (see #533) but this is a separated change that could be useful not depending on CSS stuff