feat: Add LocalRuntime and rename EventStreamRuntime to LocalDockerRuntime #5284
+234
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntime - Add new LocalRuntime implementation that runs action_execution_server directly on host - Rename EventStreamRuntime to LocalDockerRuntime for clarity - Move runtime implementations to dedicated directories - Update documentation to reflect runtime changes
- Update imports to use LocalDockerRuntime and LocalRuntime - Add LocalRuntime to get_runtime_classes() - Update _close_test_runtime to handle LocalDockerRuntime
2 tasks
- Add proper type hints for server_process - Fix stdout access safety - Fix async/await type hints - Improve error handling
enyst
reviewed
Nov 26, 2024
openhands/runtime/README.md
Outdated
| - No container overhead | ||
| - Fastest execution speed | ||
|
|
||
| Note: This runtime provides less isolation than the Local Docker Runtime. |
There was a problem hiding this comment.
@openhands-agent Does the new Local Runtime provide less isolation than the Local Docker Runtime, or no isolation at all, basically? If your answer is no isolation, then the documentation should say that clearly.
… LocalDockerRuntime
|
New OpenHands update |
|
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new LocalRuntime implementation and renames EventStreamRuntime to LocalDockerRuntime for better clarity.
Changes
Benefits
Issue fixed: #3903