Delete unreachable code and add specs for boxing

Alhadis · Sep 2, 2019 · 6f47e3c · 6f47e3c
1 parent 8678ef3
commit 6f47e3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/utils/general.mjs b/lib/utils/general.mjs
@@ -230,8 +230,7 @@ export function splitOptions(argv, niladicShort = "", monadicShort = "", monadic
  const undash = x => x.replace(/-|\s/g, "");
  niladicShort = escape(undash(niladicShort));
  monadicShort = escape(undash(monadicShort));
- monadicLong = monadicLong.split("|").filter(Boolean).map(escape).sort((a, b) =>
- b.indexOf(a) ? a.indexOf(b) ? a.localeCompare(b) : -1 : 1).join("|");
+ monadicLong = monadicLong.split("|").filter(Boolean).map(escape).sort().join("|");
  const patterns = [
  niladicShort && new RegExp(`^-([${niladicShort}][^-\\s${monadicShort}]*)${
  monadicShort ? `(?:([${monadicShort}])(\\S+)?)?` : "(\\S*)"}`),

diff --git a/test/1.1-general.js b/test/1.1-general.js
@@ -931,5 +931,10 @@ describe("General-purpose", () => {
  expect(splitOptions(null)).to.eql([]);
  expect(splitOptions(false)).to.eql([]);
  });
+
+ it("boxes string arguments into arrays", () => {
+ expect(splitOptions("-abc", "abc")).to.eql(["-a", "-b", "-c"]);
+ expect(splitOptions("-abc", "a", "bc")).to.eql(["-a", "-b", "c"]);
+ });
  });
 });