Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static path config for HA 2024.7+ #723

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix static path config for HA 2024.7+ #723

wants to merge 5 commits into from

Conversation

hmmbob
Copy link
Contributor

@hmmbob hmmbob commented Jul 2, 2024 •
edited
Loading

Fixes #722

Needs HA 2024.7+ (but the warning is only shown on 2024.7+ as well)

Tested locally, works fine

@Snuffy2
Copy link

Snuffy2 commented Jul 10, 2024

I think you need to import StaticPathConfig
from homeassistant.components.http import StaticPathConfig

@hmmbob
Copy link
Contributor Author

hmmbob commented Jul 11, 2024

I think you need to import StaticPathConfig from homeassistant.components.http import StaticPathConfig

Yeah, great catch. Did that when testing locally, forgot to add it here. Many thanks!

@AlexxIT
Copy link
Owner

AlexxIT commented Jul 11, 2024

Thanks. But I won't accept this because breaking previous versions. A lot of users continue to use 2023.

@hmmbob
Copy link
Contributor Author

hmmbob commented Jul 11, 2024 •
edited
Loading

I had an idea and made it backward compatible. Dropped the hacs.json change as well.

@hmmbob hmmbob changed the title Fix static path config Fix static path config for HA 2024.7+ Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hmmbob @Snuffy2 @AlexxIT