-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDR++ Server crashes with seg fault when float32 and sample rate above 13 mhz #1326
Labels
bug
Something isn't working
Comments
Known issue, I'll close when it's fixed |
for now i'm gonna make a temporary fix doing this: else if (cmd == COMMAND_SET_SAMPLE_TYPE && len == 1) {
dsp::compression::PCMType type = (dsp::compression::PCMType)*(uint8_t*)data;
// if(type == dsp::compression::PCM_TYPE_F32) type = dsp::compression::PCM_TYPE_I16;
if(type == dsp::compression::PCM_TYPE_F32) {
if(sampleRate >= 13000000.0) {
flog::warn("Prevented Memory Crash");
type = dsp::compression::PCM_TYPE_I16;
} else {
flog::warn("Float32");
}
}
comp.setPCMType(type);
} guess its better than the server crashing |
the fix just involves setting the size of the uint8_t stream appropriately in the compression and decompression blocks |
AlexandreRouma
added a commit
that referenced
this issue
Feb 13, 2024
Fixed |
Ahmad-Bamba
pushed a commit
to Ahmad-Bamba/SDRPlusPlus
that referenced
this issue
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FIRST: Before reporting any bug, make sure that the bug you are reporting has not been reported before. Also, try to use the nightly version if possible in case I've already fixed the bug.
Hardware
Software
Bug Description
If the sample rate of the SDR is 13 mhz or higher, the Float32 mode crashes the SDR++ server with a seg fault, my best guess, too low ram?
Steps To Reproduce
Additional info
Server console logs:
The text was updated successfully, but these errors were encountered: