Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sun Times Return Zero #3400

Closed
1 task done
tonyn0 opened this issue Sep 29, 2023 · 4 comments
Closed
1 task done

Sun Times Return Zero #3400

tonyn0 opened this issue Sep 29, 2023 · 4 comments
Labels
bug fixed in source This issue is unsolved in the latest release but fixed in master
Milestone
0.14.0 candidate

Comments

@tonyn0
Copy link
Contributor

tonyn0 commented Sep 29, 2023

What happened?

Sometimes, sun times are calculated as zero (depending on location, I hear). Requesting that "use real math" is implemented as standard.

To Reproduce Bug

Be in wrong place at wrong time. ;)

Expected Behavior

Calculations are always valid.

Install Method

Binary from WLED.me

What version of WLED?

b6

Which microcontroller/board are you seeing the problem on?

Other

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tonyn0 tonyn0 added the bug label Sep 29, 2023
@softhack007 softhack007 added this to the 0.14.0 candidate milestone Sep 30, 2023
@blazoncek
Copy link
Collaborator

Partial workaround is by custom compiling using -D WLED_USE_REAL_MATH.
The drawback is that image size will increase and also a few bytes of precious RAM will be missing.

The former may be an ESP32 issue and the latter ESP8266 issue.

@softhack007
Copy link
Collaborator

softhack007 commented Sep 30, 2023 •
edited
Loading

I'll propose a proper fix tomorrow. It seems that reverting _t math to standard functions in getSunriseUTC() will make it work. Reason is that _t functions are slightly faster, but only deliver low accuracy values.

From Discord

Wondering if I found a bug. This was working fine on v5. My sundown keeps reverting to 0's. I can get the sundown to pop up once I change something, but after I save it and leave the page, it reverts back.

Screenshot_2023-09-28_095530

Some user confirmed that the problem disappears when using standard libm functions.

Edit: sunset/sunrise = 00:00 happens when wled calculations suggest that there is no sunset/sunrise at that day; i.e. 24hrs daylight or 24hrs night.

WLED/wled00/ntp.cpp

Lines 443 to 446 in 332be7e

//7a. calculate the Sun's local hour angle
float cosH = (sin_t(DEG_TO_RAD*ZENITH) - (sinDec * sin_t(DEG_TO_RAD*lat))) / (cosDec * cos_t(DEG_TO_RAD*lat));
if (cosH > 1 && !sunset) return 0; // the sun never rises on this location (on the specified date)
if (cosH < -1 && sunset) return 0; // the sun never sets on this location (on the specified date)

softhack007 added a commit that referenced this issue Sep 30, 2023
@softhack007
fix for #3400
166316e 
replace low_accuracy math functions (sint_t, cos_t, atan_t, ...) with standard libm functions that have higher accuracy.
softhack007 added a commit that referenced this issue Oct 2, 2023
@softhack007
Merge pull request #3406 from Aircoookie/sunset_accuracy_fix
26e766e 
fix for #3400 - wrong sunset time 00:00
@softhack007 softhack007 added the fixed in source This issue is unsolved in the latest release but fixed in master label Oct 2, 2023
softhack007 added a commit to MoonModules/WLED that referenced this issue Oct 6, 2023
@softhack007
fix for Aircoookie#3400
c3a2efc 
replace low_accuracy math functions (sint_t, cos_t, atan_t, ...) with standard libm functions that have higher accuracy.
@softhack007
Copy link
Collaborator

fixed in 0.14.0

Funkelfetisch added a commit to Funkelfetisch/WLED that referenced this issue Dec 18, 2023
@Funkelfetisch
Squashed commit of the following:
5bfb04b 
commit 1ca6bdd5f9fec930fe1b5fe71588b0cbdb979981
Author: Veit Nachtmann <[email protected]>
Date:   Tue Oct 24 21:37:08 2023 +0200

    nebulite

commit dc3c745a2f04e02432fd0292ec4602c0341f2c9b
Merge: a27b41af 0092e49e
Author: Veit Nachtmann <[email protected]>
Date:   Tue Oct 24 18:30:05 2023 +0200

    Merge branch 'mdev' of https://github.com/MoonModules/WLED into mdev

commit a27b41af46fd76b7be50f9f8452b5180ab3dcd47
Merge: 871ed31f 01634450
Author: Veit Nachtmann <[email protected]>
Date:   Tue Oct 24 18:29:47 2023 +0200

    Merge branch 'mdev' of https://github.com/MoonModules/WLED into mdev

commit 0092e49eb35417851a5d53afaf3b303ebbdb26b8
Author: Ewoud <[email protected]>
Date:   Tue Oct 24 16:58:35 2023 +0200

    GFX/Preview done right if > 4096 pixels + unlimited virtual pixels in 2d

commit 7f5ddc79da711c09d454b65eb999bd80d6ce38d7
Author: Ewoud <[email protected]>
Date:   Tue Oct 24 15:34:07 2023 +0200

    PopulateNodes stability improvements

commit 2246436928b3dda32b0350e5ee893212b23ac7b7
Author: netmindz <[email protected]>
Date:   Sat Oct 21 22:15:47 2023 +0100

    Update platformio.ini

    Update to Animatrix with the fix for rgb_sanity_check

commit 5672405a88e72fb6f826ad0b00e5ec7a6ab01075
Merge: b2344ad2 3ba2fe4e
Author: Ewoud <[email protected]>
Date:   Fri Oct 20 20:15:20 2023 +0200

    Merge pull request #84 from troyhacks/WM8978

    WM8978 support for Ohmic Pico DSP, etc.

commit 3ba2fe4ee0e584640e5c8ea93ec2becaa31fa433
Author: TroyHacks <[email protected]>
Date:   Fri Oct 20 01:23:10 2023 -0400

    WM8978 support for PicoDSP, etc.

commit b2344ad21978b5d0a12cadc80d7a902dd4b9415d
Merge: 294a8724 78ebc858
Author: netmindz <[email protected]>
Date:   Tue Oct 17 19:03:41 2023 +0100

    Merge pull request #83 from MoonModules/animatrix-update

    Version of library with all rgb data set for every effect

commit 78ebc8583fe52db3a6007fa1d44ec4aa3c304797
Author: Will Tatam <[email protected]>
Date:   Tue Oct 17 18:55:05 2023 +0100

    Version of library with all rgb data set for every effect

commit 294a872462a9ca3420251e4829d6c68b3f381720
Author: Ewoud <[email protected]>
Date:   Sun Oct 15 21:43:55 2023 +0200

    json/info: brand and product configurable by compile variables

    For MM builds brand = WLEDMM
    Will be used in WLED-Native - by Moustachauve

    Changed in bh1750, bme280, pir, json.cpp and wled.h

commit 6d9af29042aaf839fcf9f28f076eeef987ca6fe9
Author: Frank <[email protected]>
Date:   Tue Oct 10 22:06:04 2023 +0200

    Polar Lights minor speedup

    * perform some calculations outside of the main loop.
    * move "mapf" to the top of fx.cpp

commit 57096ad6761c48faa629f46347cd3adebb8fd7fd
Author: Frank <[email protected]>
Date:   Tue Oct 10 11:54:51 2023 +0200

    bugfix: info page microscopic font size

    splitting CSS attributes for info and nodes, to preserve font size for info page.

commit 5476a90a69b8d4d26dbcc1f83c507b6314f703e5
Merge: 01634450 f99856e8
Author: netmindz <[email protected]>
Date:   Mon Oct 9 18:28:49 2023 +0100

    Merge pull request #76 from MoonModules/audio-sync-framecounter

    Audio sync framecounter

commit 871ed31f2a2d960800ca5f76b41a35fc4728f595
Author: Veit Nachtmann <[email protected]>
Date:   Mon Oct 9 02:41:08 2023 +0200

    added detection for the more complicated battery controller rev4

commit 01634450a0fe5f6b0ca9c8b9823c9b860465a970
Author: Frank <[email protected]>
Date:   Sun Oct 8 21:46:57 2023 +0200

    minor clarification

    so what is it ??
    ;-)

commit f99856e863f398c9e2a45ef08d5c46cf337a094e
Author: Will Tatam <[email protected]>
Date:   Sun Oct 8 19:35:26 2023 +0100

    Log packet counters

commit 9ff7f56eb893d3db14d7d06e8dc1aff74b496280
Author: Frank <[email protected]>
Date:   Sun Oct 8 19:54:14 2023 +0200

    fix for partly uninitialized sound sync packets (audioreactive)

    audioSyncPacket contains four "invisible" padding bytes added by the compiler. These need to be initialized to zero, as future versions of the protocol will make use of these fields.

commit 71abd117b5ff709814c6bb02a1548ef284dc7c70
Author: Ewoud <[email protected]>
Date:   Sun Oct 8 19:02:32 2023 +0200

    PolarLights and Octopus: deterministic + SuperSync control

    FX.cpp
    - SuperSync control on Polar lights and Octopus:  only calculate pixels for the first panel

commit 4b12f052287224bd007a39610f0da1047d91a068
Author: Ewoud <[email protected]>
Date:   Sun Oct 8 17:59:41 2023 +0200

    Nodes popup: add real fps

commit b07562659f6a08c934963e81e1457f34c1666a3f
Author: Ewoud <[email protected]>
Date:   Sun Oct 8 17:09:57 2023 +0200

    SuperSync small updates

commit 3b5c95b5e0f581866c389b9bf8c788aeb2292a3a
Author: Will Tatam <[email protected]>
Date:   Sun Oct 8 14:10:48 2023 +0100

    Try adding frame counter to detect duplicate or out of order sync frames

commit 81e57bae7e25ee8d01e57ead4a20d75af06dba53
Author: Ewoud <[email protected]>
Date:   Sun Oct 8 12:40:12 2023 +0200

    Nodes popup SuperSync ready for test

    index.js
    - cleanup code
    - reordercolumns
    - add warnings (orange) for version, bri scale and fps
    - add led output length equal to panel dimensions
    - master node order

commit 1fa5dc8ea81663f75072ecf0d660a60f7f856180
Author: Frank <[email protected]>
Date:   Sun Oct 8 01:36:08 2023 +0200

    audioreactive - spelling corrections in comments

commit 28b46d8ee3a1d7894b53304815551171be51a5d4
Author: Frank <[email protected]>
Date:   Sun Oct 8 00:25:42 2023 +0200

    ArduinoFFT optimized

    * use softhack007 variant of ArduinoFFT (10% faster)
    * small update to 16MB_V4 buildenv

commit b249a5af5e64713f23745258285252cc2bd09446
Author: Frank <[email protected]>
Date:   Sun Oct 8 00:03:11 2023 +0200

    arduino-esp32 2.0.14 still contains the left-right-swapped bug

    * use left-right-workaround up IDF 4.4.6
    * fix for small typos

commit bd847e45791f706bb3a5614e260a51d01c7b44b3
Author: Frank <[email protected]>
Date:   Sat Oct 7 20:57:45 2023 +0200

    npm run build

    daily business

commit 4e530dfa20d94e635c8abfd97bb9854ba961716a
Author: Frank <[email protected]>
Date:   Sat Oct 7 20:55:01 2023 +0200

    0.14.0-b27.32

    time to increment the minor number

commit 2a7767dda8c4b67f0dbbd35e4a89b55453bd0d79
Merge: 77cef804 a399ec8c
Author: Frank <[email protected]>
Date:   Sat Oct 7 20:42:27 2023 +0200

    Merge branch 'buildcache' into mdev

commit 77cef804174de24d0be58b9d61547dcd63963764
Merge: fea47b59 0ec54c49
Author: Frank <[email protected]>
Date:   Sat Oct 7 16:24:10 2023 +0200

    Merge pull request #73 from arneboe/fix_static_effect_timing

    Fix return value (frameDelay) of FX_MODE_STATIC

commit 0ec54c49112a8a3190eb59e7825ea91b4f4eb34c
Author: Frank <[email protected]>
Date:   Sat Oct 7 16:23:15 2023 +0200

    WLEDMM specific improvement

    WLEDMM has FRAMETIME_FIXED_SLOW which seems perfect for this usecase.

commit fea47b596574d64dcc1646c3b136adb31fbabdb0
Author: Ewoud <[email protected]>
Date:   Sat Oct 7 15:25:27 2023 +0200

    Add Ethernet type: Olimex ESP32 Gateway

    index.js:
    - add leds instead of matrix to extendedNodes array
    - split V and P ledcount

commit 15cea2b00af091178c364790b5e293a5bf860211
Author: Frank <[email protected]>
Date:   Sun Oct 1 19:04:30 2023 +0200

    optimization: only use "float" math functions

    - saves 5KB flash and some RAM
    -allow to build with -D WLED_USE_UNREAL_MATH, to restore old behaviour and save another 6KB flash

commit 6fdd1823e023305a415228acd154cb28b1bbaf29
Author: Frank <[email protected]>
Date:   Fri Oct 6 17:33:21 2023 +0200

    build number of today

commit ecb2f48c32b5691f02c44c154a40cdc81bada476
Author: Blaz Kristan <[email protected]>
Date:   Sun Sep 24 16:48:59 2023 +0200

    FX update
    - Meteor: trail & 0.13 behaviour
    - Meteor Smooth: train & 0.13 behaviour
    - Scrolling Text: rotation

commit 138ebc69de95d2ec01c1cc368b67f4d276b314f1
Author: Frank <[email protected]>
Date:   Fri Oct 6 17:24:53 2023 +0200

    npm run build

    yo'man

commit 3eb360dfe143156a8b5db699b67564a8290191c1
Author: Blaz Kristan <[email protected]>
Date:   Sun Oct 1 13:26:31 2023 +0200

    Fix for #3403

commit 7e21003f078a4513efd013f6094d45786062d3b1
Author: Blaz Kristan <[email protected]>
Date:   Sun Oct 1 13:04:05 2023 +0200

    Fix for #3405

commit e578f6ef05c94f29971f41a4bcf89f65e9441394
Author: Frank <[email protected]>
Date:   Fri Oct 6 16:27:25 2023 +0200

    Merge pull request #3420 from mountainash/fix/duplicate-viewport-declaration

    Remove duplicate `viewport` declaration, put lang=en into the right place

commit 6c71a971358764090e9d9056dc93c3db71a48eb1
Author: Frank <[email protected]>
Date:   Fri Oct 6 16:26:04 2023 +0200

    Merge pull request #3425 from mountainash/fix/git-ignore

    .gitignore Reordered & grouped

commit c3a2efce63866e3422d056b64885f3c058af660e
Author: Frank <[email protected]>
Date:   Sat Sep 30 23:34:02 2023 +0200

    fix for #3400

    replace low_accuracy math functions (sint_t, cos_t, atan_t, ...) with standard libm functions that have higher accuracy.

commit 1db950389a3dbae8d710a9ded0210a51293b61ff
Author: Ewoud <[email protected]>
Date:   Fri Oct 6 12:57:28 2023 +0200

    SuperSync button works

    index.js
    - extend checkNode function (panel 0, nrofpanels, matrix size)
    - populateNodes: add panel 0 and dummypanel

commit ffb0ad760d3587af5f3e88dc3f25ce3c049ceac4
Author: Ewoud <[email protected]>
Date:   Thu Oct 5 15:36:28 2023 +0200

    Solve gamma reset bug + super sync nodes compare and update (WIP)

    cfg.cpp: update "light" only if value set (gamma correction bug)

    index.js
    - implement SuperSync function (WIP)
    - ddpAll: refactor extendedNodes
    - populateNodes: make things more straightforwared
    - add panelX and Equal column to compare current and desired values
    - add matrix to extendednodes and set the right values (WIP)

commit cea994c282041170d4afc0c4db94ad50469fde46
Author: Ewoud <[email protected]>
Date:   Wed Oct 4 11:56:00 2023 +0200

    Deterministic mode of effects only when SuperSync is on

    Temporary - to compare both modes

    Octopus
    Soap
    CrazyBees

commit 06220946c00bc6879ec41f491cd16bbb1ca0ce91
Author: Ewoud <[email protected]>
Date:   Tue Oct 3 17:57:57 2023 +0200

    Refactor Nodes popup for SuperSync

    (WIP)

commit 76aa3072b678db49d1ccea7d44fe3f85ead8fc4c
Author: Ewoud <[email protected]>
Date:   Mon Oct 2 12:45:56 2023 +0200

    Octopus and Crazy Bees Super Sync compatible

commit 37e16247296801684d84912753fa6bd179aad0f3
Author: Ewoud <[email protected]>
Date:   Sun Oct 1 21:13:16 2023 +0200

    Make Soap effect Super Sync compatible

commit 342f99ca27ba90a264870884d094d45f2855b957
Author: Ewoud <[email protected]>
Date:   Sat Sep 30 12:23:53 2023 +0200

    Effects to Instances: effects non-deterministic: now instead of millis

    index.js
    - genPresets: Temporary for deterministic effects test: Set to 11/Raibow instead of 1/Random smooth palette

    FX.cpp
    - replace all millis() by strip.now

commit 9be4ce172128ff860eaabb95e6a27cc042e083ba
Author: Ewoud <[email protected]>
Date:   Fri Sep 29 21:46:40 2023 +0200

    Save basic panel layout in config

commit 18c62734be9f61c64b6e16d5bbd3dfe87cb3de8c
Author: Arne <[email protected]>
Date:   Sun Sep 24 17:20:59 2023 +0200

    Increase update time of static effect to avoid lag

commit 0ba8402e72eacc6788a7363846bf00ff03bf3285
Author: Frank <[email protected]>
Date:   Sat Sep 23 22:49:09 2023 +0200

    Align ADC init with WLED-SR

    Feedback from SR is "it works better with analog", so let's align the driver code as much as possible.

commit 015ce11b72ca8456c623fdbe8b534707d8e3cfbf
Author: Frank <[email protected]>
Date:   Fri Sep 22 18:52:06 2023 +0200

    esp32: 9 LED pins with audioreactive

    this allows to use 9 (instead of 8) LED pins on esp32.

commit 7425b437dae84f4e3cbe7594689c0e35e06f93e1
Author: Frank <[email protected]>
Date:   Wed Sep 20 00:43:03 2023 +0200

    (WIP) adjust Battery usermod for "MM Style"

    seems to work, but still needs more testing.

commit e28d303d4c958967546a2e7a1985d663d02c7722
Author: Frank <[email protected]>
Date:   Tue Sep 19 22:54:08 2023 +0200

    adjust RTC usermod for "MM Style"

commit acc2d3aa10d0d38db43d90033bfc56ee0ca86bd7
Author: Frank <[email protected]>
Date:   Tue Sep 19 19:33:36 2023 +0200

    clean up I2C pin handling in audioreactive (ES7243+ES8388)

    * remove double Wire.begin() - Wire cannot be re-initialized; its already started by pinManager.joinWire()
    * Only use global I2C pins; make sure that audireactive I2C settings are aligned with global I2C pins
    * minor cleanup
    * remove I2C pins from AudioSource::initialize()

    Note to self: sdaPin, sclPin are just dummy values now, good for UI consistency, but unused otherwise. Could be removed.

commit b3d9621427e89208b7b797d67c4de3a4fe974c29
Author: Frank <[email protected]>
Date:   Tue Sep 19 15:27:41 2023 +0200

    fix wrong signature of SPH0654::initialize()

    * debug messages added to different initializers
    * SPH0654::initialize() was having a wrong signature: uint8 instead of int8.

    C++ can be a real bastard ;-)

commit 89c33607bc3296748ff17f845a20682758ecde59
Author: Frank <[email protected]>
Date:   Mon Sep 18 22:05:53 2023 +0200

    SR_DEBUG shows stack high water marks

    some debug support for showing free stack space.

commit a79243135a6500e20ccddb4f9e27d1496b86a271
Author: Frank <[email protected]>
Date:   Mon Sep 18 15:56:50 2023 +0200

    Matrix effect speedup

    Typically, more than 50% of pixels are black.
    This optimization avoids to fade and rewrite already black pixels.

commit 598e0bc06143bceac8dd705f8e855c68df3808ce
Author: Frank <[email protected]>
Date:   Mon Sep 18 15:34:53 2023 +0200

    matrix: fix for a corner case (e.g. gapmaps)

    workaround for a corner case; if the reference pixels falls into a "gap" then gPC returns BLACK. Solutions is to reject BLACK.

commit f1d4bf2729538e2fd810fad1cea1c3b0c6d6f7a2
Author: Frank <[email protected]>
Date:   Mon Sep 18 14:57:15 2023 +0200

    bugfix for #3375

    * improves robustness of the Matrix effect, by dynamically adjusting the "reference color" used to identify "falling code" head pixels.
    * a bit faster, as I've removed the need to scan all pixels a second time for "black screen" detection.

    Its still not perfect, and the main loop could be simplified a lot by leveraging on the fact that all changes actually happen in the top row, and "falling" is actually just moving everything down by one pixel.

commit 0808335565773db3930361fbabf4aefb0b273c83
Author: Frank <[email protected]>
Date:   Sun Sep 17 19:31:23 2023 +0200

    npm run build

    yo'man

commit bcc0517d8717538d52ed903f2a84e5cd2c358f04
Author: Frank <[email protected]>
Date:   Wed Sep 6 11:14:43 2023 +0200

    Merge pull request #1039 from pjhatch/PJH_ADD_Linearbounce

    Pjh add linearbounce

commit fd15047220f75f084219df4f532612b723ece3ac
Author: Frank <[email protected]>
Date:   Tue Sep 5 18:39:51 2023 +0200

    Squashed commit of the following:

    commit 84148ad07a7ac94993dc9dfd0bdc6d7a8d9e47ac
    Author: Blaz Kristan <[email protected]>
    Date:   Sun Sep 3 12:34:17 2023 +0200

        Implement palette colors

    commit af3c8f66f7e77dd6306ceadf2cea26a41336e439
    Author: Blaz Kristan <[email protected]>
    Date:   Tue Aug 1 18:18:41 2023 +0200

        revert wled00.ino

    commit 3097a1b17efa06b78d52611b3a9d3c519a15ed17
    Author: Blaz Kristan <[email protected]>
    Date:   Tue Aug 1 18:13:37 2023 +0200

        minor aesthetic fixes

    commit 54b80f74b2dc8766951d55438c6bc560b33e505b
    Author: Blaz Kristan <[email protected]>
    Date:   Tue Aug 1 18:09:32 2023 +0200

        remove unused variable

    commit 9a78d28cd71da998cdd76ba826946f54ee2044bd
    Merge: 56a74bc5 1ed81793
    Author: Blaz Kristan <[email protected]>
    Date:   Tue Aug 1 18:08:29 2023 +0200

        Merge branch 'main' into PJH_ADD_Linearbounce

    commit 56a74bc54c5bbf189b1f98c6cd216956b4f6bd6c
    Author: pjhatch <[email protected]>
    Date:   Sat Aug 15 12:34:13 2020 -0500

        Update FX.cpp

        Added the improvements suggested by Gregor Hartmann

    commit a20358b61bf0c38356438c87e5c59663524e038e
    Author: pjhatch <[email protected]>
    Date:   Sun Jul 12 08:33:48 2020 -0500

        Adding 2 ball track modes

        With and without collisions

    commit 341d9d1697e9af4fdf2fbd5b4c1de935d0b5a229
    Author: pjhatch <[email protected]>
    Date:   Sun Jul 5 14:55:14 2020 -0500

        Update FX.cpp

        Still 1 bug to fix - this was a test.

    commit 9cee4243837f35431302814cc7ace13a72ab5fed
    Author: pjhatch <[email protected]>
    Date:   Sun Jul 5 14:53:14 2020 -0500

        Update FX.cpp

    commit 37cb51cfd6991f6041d663de72debfdcf349c1da
    Author: pjhatch <[email protected]>
    Date:   Thu Jul 2 14:16:25 2020 -0500

        Adding Collision

        A couple of bugs still need sorting

    commit 84b7bfb989e662e37a47d78e381105b3951311a6
    Author: pjhatch <[email protected]>
    Date:   Sun Jun 28 19:59:46 2020 -0500

        update for lost balls

        Added some protection - so that when intensity is lowered and raised some time later balls that have moved way off the track are recovered.

    commit 04d17e483956b74754002da4cb4dfcddaf932f7b
    Author: pjhatch <[email protected]>
    Date:   Sun Jun 28 19:43:56 2020 -0500

        Added Ball Track V1

        In this version the balls bounce of the edges and do not interact with one another.

commit 61cd9dfc9f8443e48644f4f851bf98b99a0ba691
Author: Frank <[email protected]>
Date:   Thu Sep 7 18:55:13 2023 +0200

    potentiometer: check that pin supports ananlogread

    newer esp32 frameworks will throw lots of warnings when trying to read from a non-analog pin.

commit 51999b65adab182a632aa653617360d47f8e7ff3
Author: Frank <[email protected]>
Date:   Sun Sep 17 18:48:43 2023 +0200

    Merge pull request #3373 from Aircoookie/ripple-tweak

    2D Ripple and Meteor effect tweak

commit de4a409c7b584c3418a87f435f05abe73cf8b3a1
Author: Frank <[email protected]>
Date:   Sun Sep 10 02:00:09 2023 +0200

    8266 optional build flags to increase IRAM

    related to #3364

commit 0fcbefb7a5ed8fb4dd478747a9f09334fa320563
Author: Frank <[email protected]>
Date:   Sat Sep 9 20:48:17 2023 +0200

    fixing a few implicit promotions to double

    any expression with at least on "double" is evaluated as double, which is slow.

commit c276515f5a68baba34f01799211963875f703f6d
Author: Frank <[email protected]>
Date:   Fri Sep 15 12:28:50 2023 +0200

    default pins for Mini shield with Lolin -S2 mini

commit 64223dbc02e0cf6d766e5246244086694ecd2cbe
Author: Frank <[email protected]>
Date:   Thu Sep 14 18:26:57 2023 +0200

    audioreactive: stack size tuning

    This gives ~3KB extra free heap on -S2.

commit da614c6f19fd323e9c271ae75b4d0697c2f157cb
Author: Frank <[email protected]>
Date:   Wed Sep 13 12:35:58 2023 +0200

    temporarality disabled ARTI-FX in _S builds

    There seem to be some incompatibilities when compiling with -O2 (optimize for speed). Root cause still unclear - further investigation needed.

commit 1ddb654bab609a72a3b1fe33cadfb801549a38b8
Author: Frank <[email protected]>
Date:   Mon Sep 11 12:02:10 2023 +0200

    autosave usermod: minor fix

    display->canDraw() is only availeable in _ALT four-line-display usermod

commit fc6c097abb173fc463fba1cadf314e3161513a4b
Author: Frank <[email protected]>
Date:   Mon Sep 11 12:00:59 2023 +0200

    putting autosave back into _M category

    fingers crossed this will not break builds where flash usage is already close to 98%

commit 0c298a45c8160817182741ca366f87e04b020b4d
Merge: 3accf2e7 d3f3f633
Author: Veit Nachtmann <[email protected]>
Date:   Mon Sep 4 15:25:03 2023 +0200

    Merge branch 'mdev' of https://github.com/MoonModules/WLED into mdev

commit 3accf2e7edf3726ab6837374f718283a2d77b1f6
Author: Veit Nachtmann <[email protected]>
Date:   Mon Sep 4 15:23:19 2023 +0200

    added build to gitignore

commit d3f3f6330b3f8784884aba82d2e7bdd95bee62e6
Author: Christian Schwinne <[email protected]>
Date:   Tue Jun 27 01:51:44 2023 +0200

    Add WiFi network scan RPC command to Improv Serial (#3271)

commit a26ff4ccbdf443955f231067e513c6739b94ae04
Author: Blaz Kristan <[email protected]>
Date:   Wed Aug 23 14:50:46 2023 +0200

    Button bugfix.

commit 2653b42a63e77dbd53a47e3d601a559cb083841e
Author: Blaz Kristan <[email protected]>
Date:   Thu Aug 31 19:10:22 2023 +0200

    Fix for #3352

commit 10ccd0e6231681f152535c3b0b7bc12b1aaa9b16
Author: Andre Lackmann <[email protected]>
Date:   Fri Jun 30 23:03:32 2023 +1000

    Removed current cycle assignment that clears current value (#3262)

commit d065e3332ffdc4b87ae626b3bd102dbde82cd88b
Author: Frank <[email protected]>
Date:   Wed Aug 30 01:04:13 2023 +0200

    Reduce static JSON buffer size on -S2/-C3

    Reduce static buffer allocation, hoping to improve overall stability.

commit c4ec9686547aa909f81993ef0d267a89be7cf55c
Author: Frank <[email protected]>
Date:   Wed Aug 30 00:50:56 2023 +0200

    -S2: only use PSRAM for JSON data

    Avoids some slowdown - generally PSRAM is too slow for storing time-critical data.

commit 95f6e7e47a5e33aa5930b97cdb281e998d5ae630
Author: Frank <[email protected]>
Date:   Thu Jul 20 22:09:48 2023 +0200

    allow Lolin Wifi Fix on -S3

commit 5e0dbfc285a8d475febaa48b86c461f11214d2e9
Author: Frank <[email protected]>
Date:   Mon Aug 28 12:53:52 2023 +0200

    -S2: slightly reduced static JSON buffer size

commit 5cf33b116b633e73e0638291fee40c8b66af827e
Author: Frank <[email protected]>
Date:   Mon Aug 28 11:59:52 2023 +0200

    add LOLIN WiFi fix for -S2 build envs (MM style)

commit c23da2b376e0560d4d67d549015cd5eb4490db9b
Author: Frank <[email protected]>
Date:   Sun Aug 27 02:16:57 2023 +0200

    Correct WLED_RELEASE_NAME

    Fix two buildenvs where release name did not match the build environment name

commit 129f5ec312e202c7c3728b06435ee9226040396a
Author: Frank <[email protected]>
Date:   Sun Aug 27 00:54:14 2023 +0200

    release preparations

    * npm run build
    * enable CI build for esp32_4MB_S and esp32S3_8MB_S (both optimized for speed)
    * add animartrix to esp32S3_8MB_S
    * workaround for gcc ICE (only happens with V4 framework and -O2 optimize for speed)

commit aa09241363d476d091e5a0c3a786940c46d48a41
Author: Frank <[email protected]>
Date:   Sat Aug 26 23:41:50 2023 +0200

    version 0.14.0-b27.31

commit bb6f84d18c85703ddfd9aab2e9731782295c712a
Author: Frank <[email protected]>
Date:   Fri Aug 25 17:26:40 2023 +0200

    pin summary: don't report "fake" conflicts with same owner

    sometimes happens in debug mode.

    GPIO    | Assigned to           | Info
    --------|-----------------------|------------
    i/o   1   debug output      !! Conflict with debug output !!      Serial TX

commit 2b34b30314b623e9396865892c7eb4c674d90aa1
Author: Frank <[email protected]>
Date:   Fri Aug 25 17:13:42 2023 +0200

    net debug for esp32_4MB_S

commit e6e30abfeb038e919a694cade0f02731cd1b93df
Author: Frank <[email protected]>
Date:   Fri Aug 25 16:51:07 2023 +0200

    8266: improve accuracy of FPS calculation

    based on a similar correction I made in upstream recently.

commit 523893be02f90be7e643f9fe4ab65682e15691fd
Author: Frank <[email protected]>
Date:   Fri Aug 25 16:18:37 2023 +0200

    8266 audioreactive: fix crash during OTA

    * fix crash when starting OTA: `Panic core_esp8266_main.cpp:191 __yield `
    * prevent sound sync reconnect during OTA

commit 07d204e43113bbca926597c4cdc68e789ab4c1a0
Author: Frank <[email protected]>
Date:   Fri Aug 25 15:00:49 2023 +0200

    enable AGC in new installs

    if SR_SQUELCH is specified by the build env, change AGC default to enabled.

commit 254013d37496f0f3f691622465fca589a27cf66e
Author: Frank <[email protected]>
Date:   Thu Aug 24 23:46:57 2023 +0200

    8266: net debug for MM style configs

    Adding net debug to all 8266 MM buildenvs

commit 730b0ece87d75b46a1bf0b77d14314a61f16113a
Author: Frank <[email protected]>
Date:   Thu Aug 24 22:56:02 2023 +0200

    cleanup for the cleanup

    eliminating a duplicate condition in `#if`

commit 31badb0e66bd8ec2b3ad374d9d75e7c67e1f87a4
Author: Frank <[email protected]>
Date:   Thu Aug 24 22:50:50 2023 +0200

    8266 onUpdateBegin, and minor cleanup

    * 8266 audioreactive: added minimal `onUpdateBegin()`
    * small cleanups

commit 63375f5c84983134317dfc808722c358f4e4a150
Author: Frank <[email protected]>
Date:   Thu Aug 24 22:21:48 2023 +0200

    esp32 audioreactive bugfix

    small mistake, huge impact: the right way is to first create our FFT task, then check if task creation was successful.

commit 6379a61828f18843092bc478a1d1f6b79460fa24
Author: Frank <[email protected]>
Date:   Thu Aug 24 18:02:38 2023 +0200

    Update CONTRIBUTING.md

commit f09fd7b50e3c8b507697398180cd90cfbc75a41f
Author: Frank <[email protected]>
Date:   Thu Aug 24 17:56:37 2023 +0200

    Update CONTRIBUTING.md

    small update for coding style

commit 9e4f040d4103fd3069bcab633ad89d690f2bf1b4
Author: Frank <[email protected]>
Date:   Thu Aug 24 14:21:47 2023 +0200

    esp8266 build envs

    new: esp8266_2MB_S
    updated: esp8266_4MB_S

commit 1b3ae20e6da833f981b7297a00af154ca6edb095
Merge: 82f90806 ecc6f1aa
Author: netmindz <[email protected]>
Date:   Wed Aug 23 18:59:45 2023 +0100

    Merge pull request #60 from MoonModules/ESP8266-Sync

    Audio sync receive only - EPS8266

commit ecc6f1aa62cc6071d0c01bcf348d44bc8a2eee26
Author: Frank <[email protected]>
Date:   Wed Aug 23 15:39:32 2023 +0200

    bugfix

    seems I was too fast with removing _P from strncmp_P

commit 1306cc041227594affa4b87b38713dd237db74cd
Author: Frank <[email protected]>
Date:   Wed Aug 23 13:19:48 2023 +0200

    show kernel debug messages in debug builds

commit 023279c702feb296cc967c0e945d5e9ac73ad527
Author: Frank <[email protected]>
Date:   Wed Aug 23 13:18:48 2023 +0200

    8266: minor buildenv updates

    * -Wno-register not needed any more (solved in FastLED 3.6.0)
    * ARDUINOJSON_DEBUG added to debug_flags
    * use WLEDMM_PROTECT_SERVICE on 8266, too

commit 3255530ee36004ea2e36ad4f966107ca38b8a693
Author: Frank <[email protected]>
Date:   Wed Aug 23 14:40:47 2023 +0200

    basic debug support on 8266

commit 82f90806095c3feeb14d3a0c1d2780484ebb6f65
Author: Frank <[email protected]>
Date:   Wed Aug 23 13:19:48 2023 +0200

    show kernel debug messages in debug builds

commit 087de861272ff48906f4ffbf76d94ca27106517b
Author: Frank <[email protected]>
Date:   Wed Aug 23 13:18:48 2023 +0200

    8266: minor buildenv updates

    * -Wno-register not needed any more (solved in FastLED 3.6.0)
    * ARDUINOJSON_DEBUG added to debug_flags
    * use WLEDMM_PROTECT_SERVICE on 8266, too

commit d221745e3fe37038a228b570ca1e9cefd043ad84
Author: Frank <[email protected]>
Date:   Wed Aug 23 12:37:30 2023 +0200

    some improvements

    * remove some internal variables (soundAgc, multAgc, ....)
    * prototype for autoResetPeak(void)
    * changed `#ifndef ESP8266` to `#ifdef ARDUINO_ARCH_ESP32`
    * replacement code for computing max sample
    * Info Page: "audio source" added (idle/receiving/not connected/Off)

commit 2cc6925f178f00e6b3445e9c4ac0962f42d1ed94
Author: Frank <[email protected]>
Date:   Tue Aug 22 23:42:03 2023 +0200

     agcSensitivity (to align um_data with esp32)

    all elements of um_data must be filled, otherwise some effects will crash.
    This adds a dummy " agcSensitivity" value that stays at 128.

commit f689d5115bfdd4b2dc17a93352a006dbafca62fe
Author: Frank <[email protected]>
Date:   Tue Aug 22 22:55:05 2023 +0200

    8266 hotfix: solving connectivity problems

    * it seems that `WiFiUDP.flsuh()` does something completely different from 8266, and  its actually causing WLED to stall on UI calls. So not usable on 8266.
    * fixing a few compiler warnings about "comparing signed and unsigned"

    NB: its a hotfix, we have to check if there are other problems on 8266. Also its definitely ugly, but it helps as a band aid.

commit 1c7d5d766d11aa195099f8bb4f00be7850a34488
Author: Frank <[email protected]>
Date:   Tue Aug 22 22:49:01 2023 +0200

    minor fix for 8266

    small typo, resulting in "A0" listed twice in the pin info.

commit 92e64b797ac56bb793aed8cad7e9e3c08b452b91
Author: Frank <[email protected]>
Date:   Tue Aug 22 22:55:05 2023 +0200

    8266 hotfix: solving connectivity problems

    * it seems that `WiFiUDP.flsuh()` does something completely different from 8266, and  its actually causing WLED to stall on UI calls. So not usable on 8266.
    * fixing a few compiler warnings about "comparing signed and unsigned"

    NB: its a hotfix, we have to check if there are other problems on 8266. Also its definitely ugly, but it helps as a band aid.

commit 3bd0f70109f76b40bbeac8c56384a72f3ce5fd92
Author: Frank <[email protected]>
Date:   Tue Aug 22 22:49:01 2023 +0200

    minor fix for 8266

    small typo, resulting in "A0" listed twice in the pin info.

commit 7d45f826daee9d1ae0cd94f57f40efc527c79881
Author: Blaz Kristan <[email protected]>
Date:   Wed Aug 16 22:11:16 2023 +0200

    Playlist saving bugfix.
    Fixes #3324

commit 28ca62a0556d1aa9a7929fb8491723ce51b43e18
Author: Frank <[email protected]>
Date:   Wed Aug 16 10:03:14 2023 +0200

    build number up

    some minor updates from upstream
    - JSON API : fix (de)allocations of pins for buttons/IR/RELAY
    - JSON API: added sync groups

commit 23916268f568a390ca466646475f321860d0a3ac
Author: Blaž Kristan <[email protected]>
Date:   Mon Aug 14 13:01:16 2023 +0200

    Merge pull request #3317 from chroma-tech/group-masks-api

    Add send and receive groups to json api

commit f447bc64408ad1bd5b257ec532e75caaf23e2ebb
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Jul 26 16:29:21 2023 +0200

    Bump certifi from 2022.12.7 to 2023.7.22 (#3301)

    Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22.
    - [Commits](https://github.com/certifi/python-certifi/compare/2022.12.07...2023.07.22)

    ---
    updated-dependencies:
    - dependency-name: certifi
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 492581b206e3b4ae37bf79bd98bd677cec949168
Author: cschwinne <[email protected]>
Date:   Wed Jul 19 18:02:57 2023 +0200

    Deallocate relay, button and IR pins prior to reallocation in JSON config parser (#3294)

commit a399ec8c99f18a9237bd06a6db2acf5610f5451c
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 21:52:13 2023 +0100

    Rebuild test

commit ca2106ad1da33715b1a8a1904c0e2d223d1f0edb
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 21:39:08 2023 +0100

    Rebuild test

commit a6f999d22eaa9157ca7024efb8c09a8444f08291
Merge: 1b5ef5c7 dbda4477
Author: netmindz <[email protected]>
Date:   Mon Aug 14 21:38:06 2023 +0100

    Merge pull request #65 from MoonModules/eth-builds

    Add Ethernet build

commit 7a7a8f8bed461a3f7bc4b23ded03eb18ca8e5ad9
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 21:35:33 2023 +0100

    Change cache key to use environment

commit 88db4c4f3579a348f182800e432a59f0a03b1513
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 21:27:26 2023 +0100

    Change cache key to use environment

commit e3b796913d33fcfdf66063609ba961d59bec3c70
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 21:24:58 2023 +0100

    Rebuild test

commit a6d3496b6815bb0d06957aedf345fa14dd0a012b
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 21:12:28 2023 +0100

    Change cache key

commit dbda447756be618dcbc49048535d35a185dbba85
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 21:07:48 2023 +0100

    Swap naming format to match 16MB eth image

commit 741fa0a81ec13c0931a97e6456dc94619f784a6d
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 20:55:24 2023 +0100

    Change cache key

commit 2d0d742fb6e09688a71738adaad3b84af4a6ae74
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 20:42:51 2023 +0100

    esp32_4MB_eth_M

commit 7762f50399932193d0fbabb3083255e0ca1d5a62
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 20:38:36 2023 +0100

    Trigger new build to test cache

commit 5293a45c7fbaffa1af47deade6e3fa7af790b625
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 20:24:53 2023 +0100

    Disable RLYPIN and BTNPIN as done with other ethernet build

commit af3a8c0dc24a99e61ba3c74b45186f9d9cc64ae8
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 20:21:06 2023 +0100

    esp32_4MB_eth_M

commit 3253a5f6178f68e6cd2a6923add264016dcd983a
Author: Will Tatam <[email protected]>
Date:   Mon Aug 14 20:12:41 2023 +0100

    Move buildcache inside ~/.platformio to be captured by caching of the CI and also make clearer to users who might want to fully reset platformio

commit 1b5ef5c7c28e9bd64610c10ed77464c44cbe4916
Author: Frank <[email protected]>
Date:   Mon Aug 14 13:25:20 2023 +0200

    fix usermod pin conflicts for pico board

commit 44b77ffdc20bcdb291ac7b71bdb7ddf9b6f0c7f6
Author: Frank <[email protected]>
Date:   Mon Aug 14 13:24:22 2023 +0200

    slightly increase buffer for oappend()

    in some situations, 10 bytes were missing for audioreactive settings.

commit 0672d1c59db61530318152ef13e419a0ab33c6fa
Author: Will Tatam <[email protected]>
Date:   Sun Aug 13 17:16:11 2023 +0100

    Fix maxVol and binNum

commit f0cc7f04ed51142681b2f6532352291c26147391
Author: Will Tatam <[email protected]>
Date:   Sun Aug 13 17:11:32 2023 +0100

    Fix maxVol and binNum

commit f4a1deba34471cd603ec520e20e790af2ca9ad76
Author: Will Tatam <[email protected]>
Date:   Sun Aug 13 16:54:16 2023 +0100

    Expose dynamics - limiter, rise and fall as calc runs on receive too

commit 96c19b6c506bb9a6668be775c3e3b4d580d39348
Author: Will Tatam <[email protected]>
Date:   Sun Aug 13 16:40:43 2023 +0100

    Revert placement of arduinoFFT.h include as per comments on PR:60

commit 36620a4efe6939688e6809394aa2896ad745a53e
Merge: eecb0e70 0ccf2b9c
Author: netmindz <[email protected]>
Date:   Fri Aug 11 21:02:59 2023 +0100

    Merge pull request #63 from MoonModules/revert-48-ES-I2C-usage

    Revert "Remove I2C related code from ES8388 and ES7243 as blazoncek proposes …"

commit 0ccf2b9c2e8ddbbedda5f649bf39694dc958f07e
Author: netmindz <[email protected]>
Date:   Fri Aug 11 20:59:34 2023 +0100

    Revert "Remove I2C related code from ES8388 and ES7243 as blazoncek proposes …"

commit eecb0e700b984b499deba9420b1c10951f42c68e
Author: Frank <[email protected]>
Date:   Thu Aug 10 13:58:57 2023 +0200

    quickfix for effect "double startup" problem

    temporary workaround until fixed in upstream.

    --> Please disable "Crossfade" in LEDs settings.

commit f7cd08c767d950a18339298753d50e689d6cb96b
Author: Frank <[email protected]>
Date:   Mon Aug 7 18:07:24 2023 +0200

    small correction

commit 3503ccd958d3191951b926893e63ff9bfc19a735
Author: Frank <[email protected]>
Date:   Mon Aug 7 18:06:31 2023 +0200

    Use MM specific I2C related functions for ES8388 and ES7243

    In contrast to upstream, MM follows a "no pin stealing" approach, so the Wire interfaces are only initialized when needed.
    pinManager.joinWire() will take care of the details, and will return false if something went wrong.

commit e19e464e13073c513d4e337385d2062c6c06f366
Merge: 1b308ed3 b62e9f72
Author: netmindz <[email protected]>
Date:   Mon Aug 7 02:05:22 2023 -0700

    Merge pull request #48 from netmindz/ES-I2C-usage

    Remove I2C related code from ES8388 and ES7243 as blazoncek proposes …

commit 1b308ed3d9c7ae47a5ebd148de3e5f80d488c8bd
Author: Frank <[email protected]>
Date:   Sun Aug 6 23:11:11 2023 +0200

    Version ++

commit 2ce8b929ca27b0d1876c2812c18d70544105fc83
Author: Blaz Kristan <[email protected]>
Date:   Tue Jun 6 20:56:33 2023 +0200

    Fix for #3204

commit 7002420a0cd027410c3ae3cdd67189c389baeccc
Author: Frank <[email protected]>
Date:   Sat Aug 5 23:29:23 2023 +0200

    effects bugfix: prevent crash when SEGLEN==1

    * Blurz and a few other effects would crash (or behave unexpectedly) for single pixel segments
    * replaced a few "MAX" by "max", because MAX will evaluate its arguments twice so its very inefficient.

commit f35f2c3a3ab27f12d04aab566bb666348161a1ee
Author: Frank <[email protected]>
Date:   Sat Aug 5 15:33:36 2023 +0200

    Default = preview gamma correction enabled.

commit 8e678ffa5e40b12b6a07992eb92bb171fd253c74
Author: Frank <[email protected]>
Date:   Sat Aug 5 00:06:58 2023 +0200

    allow gamma corrected preview without gamma corrected LEDs

commit f010adfe242cfa4797ad960b81e3659fb7b84dbb
Author: Frank <[email protected]>
Date:   Fri Aug 4 22:03:53 2023 +0200

    experimental: preview with gamma correction

    .... actually we undo gamma adjustments, because screens (laptop, pad, etc) will apply their own gamma corrections.

    Activate in LED settings: "Use Gamma correction for preview"

    Colors in WLED are sometimes gamma corrected, sometimes not. This change tries to make the best out of the color mess, but its still not working properly in all configurations.

commit 477cb11b36e3f36bb0d75eb23e30cdd0637f8f77
Author: Frank <[email protected]>
Date:   Tue Aug 1 12:55:04 2023 +0200

    disable ESP-NOW remotes in ethernet build (may crash)

    ESP-NOW requires wifi. It will crash with ethernet connection.

commit 30d2757db9078c7cd6dcd19ecc21e362f4efe1c1
Author: Frank <[email protected]>
Date:   Tue Aug 1 12:53:36 2023 +0200

    version of the day

commit c13b32e06a37c96fd971dd1303338f95ebca6d25
Author: Frank <[email protected]>
Date:   Tue Aug 1 11:53:32 2023 +0200

    esp-now remote: fix crash with AP = Always

    initialize ESPNOW only when Wifi (STA or AP) is running

commit 05a600ef01b61861900f2f32cd94ed42ac98d849
Author: Frank <[email protected]>
Date:   Sun Jul 30 22:10:35 2023 +0200

    npm run build

commit e4338fcaf7c38a1930ca4842dfaf47f7d847d1d5
Author: Frank <[email protected]>
Date:   Sun Jul 30 21:58:47 2023 +0200

    version bump 0.14.0-b26.30

commit 54d04eca9b713261428875269ea0a594a4244f0c
Merge: 70490647 331089a8
Author: Frank <[email protected]>
Date:   Sun Jul 30 21:50:19 2023 +0200

    Merge branch 'preview_espnow_pr3237' into mdev

commit 331089a8d93825f81063f2b081ec8573806004fd
Author: Frank <[email protected]>
Date:   Sun Jul 30 21:42:05 2023 +0200

    esp-now remote: reduce number of exported functions

    too many global variables and functions ... this makes stuff 'static' that can remain at file scope

commit 704906472b8226bffff0344376e2220a4eb74edd
Author: Frank <[email protected]>
Date:   Sun Jul 30 19:28:58 2023 +0200

    (part2) lossless getPixelColor() where needed

    more places where setUpLeds() is needed now.

commit 67491d91c9d33c9bc630f869e4aa0023a5268583
Author: Frank <[email protected]>
Date:   Sat Jul 29 23:57:47 2023 +0200

    freqMap effect enhancements

commit be6f6412d6d7fcab1bc464912b21479b36dc548a
Author: Frank <[email protected]>
Date:   Sat Jul 29 23:00:27 2023 +0200

    effect parameter tinkering

    * freqmap: fade faster
    * Lissajous HD mode: color follows rotation

commit 55b84d07e8f90754aadfa38774b9e75438d79b7c
Author: Frank <[email protected]>
Date:   Sat Jul 29 17:12:10 2023 +0200

    audio core improvements

    * DC blocker: use higher quality filtering on boards with FPU (-S3 and classic esp32)
    * experimental: build option to increase audio task priority - reduces latency

commit ab5cf95be47b12d7ab715f6d9648211ad27cfbfe
Author: Frank <[email protected]>
Date:   Sat Jul 29 03:07:08 2023 +0200

    always define WLEDMM_PROTECT_SERVICE

    moved from MM specific platformio.ini into wled.h

commit e215521f505e05abfb6d101a0dc9de11606b9a31
Author: Frank <[email protected]>
Date:   Fri Jul 28 22:24:13 2023 +0200

    pio updates: esp32_16MB_S,  esp8266_4MB_M

    * new [env:esp32_16MB_S], includes animartix !
    * add esp8266_4MB_M to nightly builds

commit 044a87b0b7046693cd394e4078d70c00855c910b
Author: Frank <[email protected]>
Date:   Fri Jul 28 21:33:45 2023 +0200

    pio: all animartix dependencies in one place

    * central place for animartix dependencies
    * removed animartix from `esp32_4MB_V4_M` (V4 "M" build  - flash size exceeded)

commit adb3a121294568593acacb9f7432a7ef2e70c033
Author: Frank <[email protected]>
Date:   Fri Jul 28 21:04:59 2023 +0200

    small speedup: IRAM_ATTR_YN colorBalanceFromKelvin

commit f966b17f5a8f22c7e2f52a8f8afe364b870ce348
Author: Christian Schwinne <[email protected]>
Date:   Mon Jun 26 00:17:34 2023 +0200

    Remove obsolete Visual Studio files

commit 8b25e78a7c973117fc6b9eec64da91dc0d13b194
Author: Titanium177 <[email protected]>
Date:   Sat Jul 1 23:18:02 2023 +0200

    Edited Metadata for effect 5 & 8 to be availible on just 1 Pixel (PWM) (#3275)

commit d8991927947014c68aa01e2c66ede465988985af
Author: Frank <[email protected]>
Date:   Fri Jul 21 16:09:01 2023 +0200

    2D Drift: minor optimization

    moving "t/20" out of the main loop gives some speedup.

commit 9b7f690708d08f9712aa41c964878c52c6672def
Author: Frank <[email protected]>
Date:   Mon Jul 17 20:38:34 2023 +0200

    Minor correction (slider names)

    "Time delay" is actually "speed" - bigger values make the effect run faster.

commit 553ac7bd82af02adf247785d694e30e4f6c4ca91
Author: Frank <[email protected]>
Date:   Fri Jul 28 20:37:37 2023 +0200

    remove some over-optimizations (FASTPATH)

commit 866c17f9e17e1fe94672d28f9aaa27a28354693f
Author: Frank <[email protected]>
Date:   Fri Jul 28 12:25:30 2023 +0200

    pio: add pico "V4" to regular build

commit 3446044b81bb339c324e5ec638a78ca5ff4f1f4d
Merge: 07939ad7 2393e86f
Author: Frank <[email protected]>
Date:   Fri Jul 28 10:47:24 2023 +0200

    Merge branch 'mdev' into preview_espnow_pr3237

commit 2393e86f1120c498991d0146a0063f6199c32991
Author: Frank <[email protected]>
Date:   Fri Jul 28 10:41:34 2023 +0200

    build ++

    increment build number

commit 10c416338c4c9a00132ccf85a2e474935667db93
Author: Frank <[email protected]>
Date:   Fri Jul 28 10:39:50 2023 +0200

    avoid spurious "assert" crashes inside wifi core

    Builds with the "standard" V3.x platform core showed random assert crashes, so lets ignore espressif and bring back `-D NDEBUG`

commit 07939ad70fb9360c0e7897bf11fa328a77455d87
Author: Frank <[email protected]>
Date:   Thu Jul 27 18:36:40 2023 +0200

    add missing constant for 8266

commit adac40d585a9d55a616b6dfb1267962581d4db03
Author: Frank <[email protected]>
Date:   Thu Jul 27 18:31:18 2023 +0200

    post merge

    *npm run build
    * changed a few debug messages into user messages
    * replaced 0 with ESP_OK

commit 5e20f94b8e93b9076911e4017f84d96544b4d53b
Author: Clayton Sims <[email protected]>
Date:   Thu Jun 22 04:06:19 2023 -0400

    Support for ESP-NOW Wireless Remote Control (#3237)

    * Initial checkin for ESP-NOW remote feature

    * cleanup irrelevant comment

    * don't bring in espnow package includes when feature disabled

    * Formatting and removing inaccurate call mode hardcoding

    * Fork ESP Now code by platform (8266 v. esp32)

    * compiled html update

    * Disable ESP-NOW remote by default on ESP32 until tested

    * Enable ESP-NOW remote for ESP32

    * Rename ESP NOW define

    ---------

    Co-authored-by: cschwinne <[email protected]>

commit 27d4128e2c318049590589fb263fe1603c250979
Author: Frank <[email protected]>
Date:   Thu Jul 27 16:24:42 2023 +0200

    lossless getPixelColor() where needed

    after upstream PR https://github.com/Aircoookie/WLED/pull/3091, getPixelColor() does not restore brightness any more.

    So all effects that rely on previous colors now need the LEDs buffer: getPixelColor, blenPixelColor, fade_out, blur, fadeToBlackBy

    This change is an intermediate solution until upstream PR https://github.com/Aircoookie/WLED/pull/3280 is stable enough for merging.

commit 9d218299c4ab73cf69b9f09319d0f3376d9e6a30
Author: Will Tatam <[email protected]>
Date:   Thu Jul 27 13:04:52 2023 +0100

    Fix palette preview of Audio Responsive Ramp

commit e7209db038c8a8db64b33fff0a446d412a4836fb
Author: Will Tatam <[email protected]>
Date:   Thu Jul 27 12:19:13 2023 +0100

    Fix compile errors for um_data not present on receive node

commit baff1a96ac0f7151ed93eaa4c054ffef4d06d54d
Author: Will Tatam <[email protected]>
Date:   Thu Jul 27 12:10:26 2023 +0100

    add comment about limitSoundDynamics

commit 1b4bd50e26bfeb8018980841a38bb4ff488fceb7
Author: Will Tatam <[email protected]>
Date:   Thu Jul 27 12:08:42 2023 +0100

    soundAgc should be none by default

commit 3367039605c29a82ce27fa72e62d27c0a146c261
Author: Will Tatam <[email protected]>
Date:   Thu Jul 27 12:04:53 2023 +0100

    Fix compile errors for packet type

commit 555ea5c9b28a2e76bcbbea658404db1557c68323
Author: Will Tatam <[email protected]>
Date:   Thu Jul 27 11:57:28 2023 +0100

    Fix compile errors for soundAgc and limitSoundDynamics - but not ideal, should only be on the sender

commit 39db568ca9e5d028edbd3cea6955a04fde99e1df
Author: Frank <[email protected]>
Date:   Thu Jul 27 12:45:14 2023 +0200

    increase STACK_BUF_SIZE after PR#59

    * increase buffer by 64 bytes (sting added in AR usermod)
    * better diag message when buffer is full
    * change "Arduino  max stack" to debug message

commit d23ca8beaf272f3c5dd4b1830d48d8bfdbbb0c6d
Author: Frank <[email protected]>
Date:   Wed Jul 26 21:59:49 2023 +0200

    PSRAM: slightly reduce static JSON buffer size

commit 1477798bb6ce580af3b58302079aff9da8c77c3b
Merge: 6521717e 9968b1f9
Author: Frank <[email protected]>
Date:   Wed Jul 26 15:38:52 2023 +0200

    Merge pull request #59 from MoonModules/sync-label

    Add extra label to give better info as to what sync actually is

commit 6521717e90eedfa31d08fea506d639a3009ea020
Author: Frank <[email protected]>
Date:   Wed Jul 26 13:30:44 2023 +0200

    consider human hearing for "Major Peak" frequency

    The "Major Peak" (for double-notes effects) was computed on the raw FFT results.
    However the human ear is more sensitive to higher frequencies (pink noise profile).

    This code change considers human ear properties for major peak computations.
    Effects like "freqmap" will look much more vivid afterwards, as higher frequencies will now have a stronger influence (harmonics are still suppressed properly).

commit 03de8ac0add1263cc0778b0adfc052ecaa8145f4
Author: Frank <[email protected]>
Date:   Wed Jul 26 13:03:58 2023 +0200

    ripple effects: bugfix for 1D

    ripple effects were showing random crashes in 1D mode.
    Root cause: negative and out-of-range index passed to getPixelColor(i, col).

commit 90c4868c2817a76c84096a69f7f076278d9ade06
Author: Frank <[email protected]>
Date:   Wed Jul 26 12:47:01 2023 +0200

    npm run build

    yo-man

commit aff0e59ff07597d95124717e2785f24036dbcb24
Author: Frank <[email protected]>
Date:   Wed Jul 26 12:42:00 2023 +0200

    cleanup and clarifications

commit c728a511ce3d8e1ba26b0fe6b36876f9528a24ce
Author: Frank <[email protected]>
Date:   Wed Jul 26 12:31:24 2023 +0200

    MM specific source code is under GPLv3

    MM specific source code is subject to GPLv3. The GPL license is more open (copyleft) than MIT, so "upgrading" our MM specific enhancements satisfies the more relaxed licensing terms from upstream.

commit 46a5bafa0bb41d6c952ff7cbae5ce483374470b4
Author: Frank <[email protected]>
Date:   Wed Jul 26 12:13:11 2023 +0200

    preserve Aircoookie LICENSE

commit 7a417713829cc5d1690bef2dbe3490346a15b818
Author: Will Tatam <[email protected]>
Date:   Wed Jul 26 02:31:24 2023 +0100

    Attempt at creating audio sync listen EPS8266

commit a7e0ba56e4bc67b37d8dc67d0b124d6b062a3f18
Author: Will Tatam <[email protected]>
Date:   Tue Jul 25 21:19:53 2023 +0100

    Attempt at creating audio sync listen EPS8266

commit a97cc1ddcd0d3df12ffa0ca999e9cc52ce100c58
Author: Frank <[email protected]>
Date:   Tue Jul 25 22:01:13 2023 +0200

    Update readme.md

    Correct some links and references

commit 565293ca8c8b3cc6fda8b18a81e721d55a49c01a
Author: Will Tatam <[email protected]>
Date:   Tue Jul 25 19:58:08 2023 +0100

    Attempt at creating audio sync listen EPS8266

commit a44c14aa9e37efaf9e2573b8fd4a429630eaa5e9
Author: Will Tatam <[email protected]>
Date:   Tue Jul 25 19:47:57 2023 +0100

    Attempt at creating audio sync listen EPS8266

commit 9968b1f9d11561e25954b87e309b63012aa0d036
Author: Will Tatam <[email protected]>
Date:   Tue Jul 25 16:53:36 2023 +0100

    Add extra label to give better info as to what sync actually is

commit 512c6689f2dead6a1b11ea3ba40b13314b70115e
Author: Frank <[email protected]>
Date:   Sun Jul 23 23:50:44 2023 +0200

    typos

commit 5837df8ef44aa8a714e25cae61dfd0feaa70ff61
Author: Frank <[email protected]>
Date:   Sun Jul 23 23:45:57 2023 +0200

    platformio: speed version for ESP32-S3, minor updates

    * added [env:esp32S3_8MB_S] with optimization for speed
    * minor cleanups for MM environments

commit b62e9f7278e45ddc8940e6149894dd0d0a584147
Author: Will Tatam <[email protected]>
Date:   Mon May 29 18:30:48 2023 +0100

    Remove I2C related code from ES8388 and ES7243 as blazoncek proposes that they are not required if we are always using the system default I2C bus
@blazoncek blazoncek mentioned this issue Dec 20, 2023
Closed
1 task
@softhack007
Copy link
Collaborator

See #3601.
A more robust solution will be availeable with release 0.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed in source This issue is unsolved in the latest release but fixed in master
Projects
None yet
Milestone
0.14.0 candidate
Development

No branches or pull requests
3 participants
@blazoncek @tonyn0 @softhack007