Add module 5: Penalty in case of exceeding legal limit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvenVw
changed the title
gerardhros
reviewed
May 10, 2024
| @@ -45,11 +46,14 @@ createApusDataset <- function(farms = NULL, cultivations, fertilizers, fields_ma | |||
| self$farms_count <- 100 | |||
| } | |||
|
|
|||
| fines <- dcast(fines, . ~ norm, value.var = 'fine')[, 2:4] | |||
| self$fines <- torch::torch_tensor(as.matrix(fines), device = device) | |||
There was a problem hiding this comment.
not better to use mget(colnames) ?
gerardhros
reviewed
May 10, 2024
| fields.fertilizers.dose.n_workable <- doses * fertilizers.p_n_workable | ||
| fields.dose.n_workable <- torch::torch_sum(fields.fertilizers.dose.n_workable, dim = 3) | ||
| farms.dose.n_workable <- torch::torch_sum( fields.dose.n_workable , dim = 2) | ||
|
|
There was a problem hiding this comment.
workable is a bad translation of "werkzaam". For now ok, but for transparency replace by nitrogen fertilizer replacement value (nfrv) or effective nitrogen.
There was a problem hiding this comment.
and for later update, distinguish between the norms given by government and by the agronomic ones.
gerardhros
reviewed
May 10, 2024
| @@ -2,5 +2,5 @@ | |||
|
|
|||
| ## Added | |||
| * Adds `apus` object with the functions `addField`, `trainModel` and `optimizeFertilizerChoice` | |||
| * Adds for the cost function module 1 and 2 | |||
| * Adds for the cost function module 1,5 and 6 | |||
There was a problem hiding this comment.
please add in brackets behind the number the main topic/issue of the module
gerardhros
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Fixed