refactor(sdk): Move trace processing from SDK to BE #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move trace processing from SDK to BE. Add locals to CreateSpan, SpanDB, etc. Fix RAG evaluators error handling. Add dump trace.json in @entrypoint. Remove 'block' in Tracing(). Use existing encoder instead of json.dumps().
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:L
aybruhm
approved these changes
Jul 26, 2024
|
I'm looking into the failing backend tests. |
aybruhm
deleted the
feature/rag/move-trace-processing-from-sdk-to-backend
branch
aakrem
reviewed
Jul 26, 2024
| @@ -344,130 +352,3442 @@ def test_auto_levenshtein_distance(output, data_point, settings_values, expected | |||
| "message": "aloha", | |||
| }, | |||
| "trace": { | |||
There was a problem hiding this comment.
@aybruhm @jp-agenta
Can we find a better approach to parameterize the trace please.. it will be hard to work on a 3k-line file..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move trace processing from SDK to BE. Add locals to CreateSpan, SpanDB, etc. Fix RAG evaluators error handling. Add dump trace.json in @entrypoint. Remove 'block' in Tracing(). Use existing encoder instead of json.dumps().