This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
JSON decoding bugfix and other small improvements #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russelldavies
force-pushed
the
master
branch
from
6305569
to
881acf5
Compare
russelldavies
force-pushed
the
master
branch
from
881acf5
to
c608237
Compare
fedor
added a commit
that referenced
this pull request
Nov 12, 2015
JSON decoding bugfix and other small improvements
|
@russelldavies thanks, merged |
|
@russelldavies I'd like to follow up. After merge I've reviewed the logic again and found it breaks parsing of errors returned by API (e.g. invalid API key). So I've changed it again (keeping correct handling of JSON decode fails). Also your changes to APIRequestException ensures that error object interfaces would work if input is either error object (dict) or string. However it doesn't cover the case if object with unexpected format is passed. So I've changed this part also. Code: https://github.com/AfterShip/aftership-python/blob/master/aftership/__init__.py Thanks again! |
|
@korshunov Great, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the Aftership API can send an erroneous response which causes a
ValueErrorto be thrown. It's preferable for clients to only have to catch anaftership.APIRequestException.Other changes are small tweaks that makes the SDK a bit more useful.