authentication: add AES support #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Python SDK only support basic API key authentication. This patch adds the support for AES authentication which is important if you want to properly secure your requests. Documentation is updated too.
|
@realitix Thank you for your support for API key AES signature authentication. We think this PR is a broken change of only support |
|
Ok @YoungWing, take my code and just update the headers in sign_request by replacing aftership-api-key to as-api-key and it will work without breaking change. |
|
yes. If your API-Key is created this year, it is working to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Python SDK only support basic API key authentication. This patch adds the support for AES authentication which is important if you want to properly secure your requests.
Documentation is updated too.