Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make coveralls a dev dependency #25

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

afaulconbridge
Copy link
Contributor

Coveralls should be a dev dependency, so that when using Aftership in production it doesn't bring coveralls and it's dependencies in too.

@alviezhang alviezhang self-requested a review November 11, 2020 02:37
Copy link
Member

@alviezhang alviezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@alviezhang alviezhang merged commit c149b78 into AfterShip:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants