Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and refactor the code #24

Closed
wants to merge 3 commits into from
Closed

Fix typo and refactor the code #24

wants to merge 3 commits into from

Conversation

MarcSteven
Copy link

@MarcSteven MarcSteven commented Nov 6, 2020 •
edited
Loading

@Bossa573 @alviezhang
I had refactored the code.
Please reviewed the code.

@MarcSteven MarcSteven changed the title Fix typo Fix typo and refactor the code Nov 9, 2020
@alviezhang alviezhang self-requested a review November 11, 2020 02:43
alviezhang
alviezhang requested changes Nov 11, 2020
View reviewed changes
Copy link
Member

@alviezhang alviezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. However, there are some problems in your PR:

  1. Commit history is not clean, you should rebase your commits instead of produce new merge commit.
  2. Travis CI is not passed
  3. Please always keep you branch fresh

@MarcSteven
Copy link
Author

@alviezhang Ok, this week I will review and then modify the code.

@Bossa573
Copy link
Member

Bossa573 commented Mar 8, 2021

closing PR due to inactivity

@Bossa573 Bossa573 closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alviezhang alviezhang alviezhang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcSteven @Bossa573 @alviezhang