Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Prepare for release #12

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Prepare for release #12

merged 2 commits into from
Feb 26, 2020

Conversation

alviezhang
Copy link
Member

No description provided.

@alviezhang alviezhang changed the title Refresh Prepare for release Feb 26, 2020
@alviezhang alviezhang requested a review from a team February 26, 2020 07:14

from setuptools import setup

here = path.abspath(path.dirname(__file__))
here = os.path.abspath(os.path.dirname(__file__))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small question, why not os.getcwd()?

Copy link
Member Author

@alviezhang alviezhang Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users may be in a different directory from this script.

For example, we could execute build command from the parent directory:

python aftership-sdk-python/setup.py ...

In this scenario, use os.getpwd would result in the wrong directory.

Usually, we location script location use os.path.abspath(os.path.dir(__file__)) instead of os.get_pwd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok

@alviezhang alviezhang merged commit 642e76d into AfterShip:refresh Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants