This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Prepare for release #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zi-yao-lu
reviewed
Feb 26, 2020
|
|
||
| from setuptools import setup | ||
|
|
||
| here = path.abspath(path.dirname(__file__)) | ||
| here = os.path.abspath(os.path.dirname(__file__)) |
There was a problem hiding this comment.
just a small question, why not os.getcwd()?
There was a problem hiding this comment.
Users may be in a different directory from this script.
For example, we could execute build command from the parent directory:
python aftership-sdk-python/setup.py ...In this scenario, use os.getpwd would result in the wrong directory.
Usually, we location script location use os.path.abspath(os.path.dir(__file__)) instead of os.get_pwd
sujiongming-git
approved these changes
Feb 26, 2020
zi-yao-lu
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.