Migrate plugin type settings to plugin rez configs #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ily add plugin settings to our documentation Signed-off-by: BryceGattis <[email protected]>
JeanChristopheMorinPerso
requested changes
May 12, 2024
| @@ -1212,46 +1212,7 @@ | |||
| # common to all plugins of that type. | |||
|
|
|||
| plugins = { | |||
There was a problem hiding this comment.
I'm curious to know what would happen if we removed this entirely from here.
There was a problem hiding this comment.
Running rez config plugins is how I've been verifying that my changes are working. Removing this line and attempting to run rez config plugins causes an error:
Traceback (most recent call last):
File "e:\code\rez\venv\Lib\site-packages\rez\cli\config.py", line 53, in command
data = data[key]
~~~~^^^^^
KeyError: 'plugins'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "E:\Code\rez\venv\Scripts\rez\rez.exe\__main__.py", line 7, in <module>
File "e:\code\rez\venv\Lib\site-packages\rez\cli\_entry_points.py", line 69, in run_rez
return run()
^^^^^
File "e:\code\rez\venv\Lib\site-packages\rez\cli\_main.py", line 189, in run
returncode = run_cmd()
^^^^^^^^^
File "e:\code\rez\venv\Lib\site-packages\rez\cli\_main.py", line 181, in run_cmd
return func(opts, opts.parser, extra_arg_groups)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "e:\code\rez\venv\Lib\site-packages\rez\cli\config.py", line 55, in command
raise ValueError("no such setting: %r" % opts.FIELD)
ValueError: no such setting: 'plugins'
|
Tests should pass if you rebase your branch. |
Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: BryceGattis <[email protected]>
Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
+ Coverage 58.29% 58.39% +0.10%
==========================================
Files 126 126
Lines 17159 17163 +4
Branches 3505 3506 +1
==========================================
+ Hits 10002 10023 +21
+ Misses 6493 6474 -19
- Partials 664 666 +2 ☔ View full report in Codecov by Sentry. |
|
/easycla |
|
EasyCLA check is passing now. |
JeanChristopheMorinPerso
merged commit 89a3b37
into
AcademySoftwareFoundation:main
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate plugin type settings to plugin rez configs so we can more easily add plugin settings to our documentation.
This change is based on JC's suggestion here.