Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of rez.vendor.enum with the built-in enum module #1649

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Replace usages of rez.vendor.enum with the built-in enum module #1649

merged 1 commit into from
Feb 17, 2024

Conversation

predat
Copy link
Contributor

@predat predat commented Feb 16, 2024

resolve #1648

@predat predat requested a review from a team as a code owner February 16, 2024 22:32
@JeanChristopheMorinPerso JeanChristopheMorinPerso added the Blocked by DCO Waiting on commit signoff label Feb 16, 2024
@JeanChristopheMorinPerso
Copy link
Member

Thanks @predat! Can you sign-off your commit please? See https://github.com/AcademySoftwareFoundation/rez/pull/1649/checks?check_run_id=21673415545 for instructions on how to do it.

Also, am I right to think that enum is used in some of our vendored modules that?

@predat
Copy link
Contributor Author

predat commented Feb 17, 2024 •
edited
Loading

Also, am I right to think that enum is used in some of our vendored modules that?

Yes, it’s also used in vendor/pika for exemple

@JeanChristopheMorinPerso JeanChristopheMorinPerso removed the Blocked by DCO Waiting on commit signoff label Feb 17, 2024
@JeanChristopheMorinPerso
Copy link
Member

@predat We can leave rez.vendor.pika untouched. We are planning on reviewing our use of vendored dependencies soon.

JeanChristopheMorinPerso
JeanChristopheMorinPerso approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 3ce72ac into AcademySoftwareFoundation:main Feb 17, 2024
52 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the Next milestone Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanChristopheMorinPerso JeanChristopheMorinPerso JeanChristopheMorinPerso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Replace usages of rez.vendor.enum with the built-in enum module
2 participants
@predat @JeanChristopheMorinPerso