a patch to Makefile.menhir for ocaml-non-native architctures. #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch and apologies for the late reply. I think that with recent enough versions of Menhir the issue goes away, because the library is always menhirLib.cmxa or menhirLib.cma, but no longer menhirLib.cmx nor menhirLib.cma. Then, the general .cmxa -> .cma rule for bytecode-only builds in Makefile.extr handles the situation. Or so it seems on my test. I'm closing this PR, but please do comment if I missed something. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD ports recently updated CompCert to 3.13, but does not work for ocaml-non-native architectures.
The problem comes from Makefile.menhir expecting either menhirLib.cmxa or .cmx is available.
It assumes ocaml native compilation environment.
This patch adds one more condition using OCAML_NATIVE_COMP which is prepared by configure, to adjust MENHIR_LIBS according to ocaml-native or ocaml-non-native environment.
I confirmed this patch works in OpenBSD ports, and believe it's useful for any other environments.