This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Fix/mobile banner width #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some browsers/devices the SVG in the banner was ignoring the w-screen directive and not filling the screen. I have scaled up the SVG to fix this issue. I also scaled up the entire SVG to look a bit better on all devices. I increased the negative y margin to support the larger size. This may need testing as this type of hard-coding tends to be fragile. Testing on 1080 monitor and multiple responsive settings. Should be tested to support 1440 as well, may need new media queries to support this screen size.
Change 'business network management' to 'search engine optimization', sort about section bullet points.
The styling to increase the SVG scale reintroduced the unexpected line between the main banner div and the SVG. Tweaked the margin on the SVG container div to fix line. Removed negative margine on SVG due to being redundant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweaks to fix banner SVG across browsers and devices. Tweaked some of the wording on about sections while I was at it.