This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Feature/full restyle #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nextjs cannot handle image URLs in the component directory. Image has to be in public. In the future we should just update this to use a proper CDN. Perhaps we can look into a better solution for writing reusable components in the future.
This version does not include mobile responsiveness for about sections
|
This includes changes to files that are no longer used and are not currently planned to be used. Any components that are not currently being rendered are not currently planned to be in the site. They can be ignored for this review. Or we could consider cleaning up the project now if the design is finalized. |
I removed the about cards and cards components as well as the split display component.
The entire site is using the new font. I have also added some minor tweaks on both mobile and desktop for spacing on about sections.
There is a known bug where navigating via anchor tag destroys the site. This appears to be a nextjs issue, perhaps a problem with lazy loading?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new restyle for the site, but not a fully finalized version. It includes mobile responsiveness and the new designs as outlined in figma. There is currently no footer, but that is still a planned feature.