Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully Implement Nuxt UI to Replace Jinja Templates #120

Merged
merged 48 commits into from
Jun 18, 2024

Conversation

fisher60
Copy link
Member

Summary

I have fully written the new UI into Nuxt. This new UI uses the abandon tech color theme and logo, but the overall design of the site is still up for discussion and design. This UI is by no means the final product and does not need to be a full representation of our final UI, but it is an improvement over the existing UI and offers the same functionality.

Any part of this UI may change in the future. Some design discussion would be appreciated to ensure the UI is nice enough to be used in production, but larger redesigns and more nit-picky suggestions may not be helpful at this stage.

Home Page
image

Creating a new application
image

developer applications with multiple apps
image

developer application detail page with callback URIs
image

reset dev app token modal
image

Token has been reset modal
image

Delete app modal (redirects to developer-applications page on successful delete)
image

New login page
image

@fisher60
Copy link
Member Author

This pull request is still a draft as it requires a lot of work on the build/deploy and dev environment to get this in a state where it can be used. The current changes destroy the existing, jinja template UI and therefore must be all-inclusive.

Daisy UI does not allow easily modifying the background color of buttons with colors defined outside of the daisy theme since it would require overriding the hover effects as well. It is much easier to create our own.
…pp pages to not use nuxtlink, create component for copying to clipboard
@fisher60 fisher60 requested a review from GDWR June 16, 2024 04:57
Copy link
Contributor

@GDWR GDWR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments are suggestions, except one which states it.

Please resolve them as you desire. Its looking really really good.

site/pages/developer-applications/index.vue Outdated Show resolved Hide resolved
site/pages/developer-applications/[id].vue Outdated Show resolved Hide resolved
site/pages/developer-applications/[id].vue Outdated Show resolved Hide resolved
site/pages/developer-applications/[id].vue Outdated Show resolved Hide resolved
site/pages/developer-applications/[id].vue Outdated Show resolved Hide resolved
site/components/CopyString.vue Outdated Show resolved Hide resolved
site/components/LoginButton.vue Outdated Show resolved Hide resolved
site/components/NavLinkButton.vue Outdated Show resolved Hide resolved
site/pages/developer-applications/[id].vue Outdated Show resolved Hide resolved
site/pages/login.vue Outdated Show resolved Hide resolved
@fisher60 fisher60 marked this pull request as ready for review June 18, 2024 04:38
@fisher60 fisher60 requested a review from GDWR June 18, 2024 04:38
@fisher60
Copy link
Member Author

After many hours of pain, this should be ready for review. pre-commit is not working locally, so linting is a pain. This will need to be fixed. We can dedicate a new PR to this if the problem is not simple.

@fisher60
Copy link
Member Author

Closes #81 #82

This .env should only be used with `yarn dev` and can cause confusing issues if the website is being built with docker compose and env vars are not set correctly.
@fisher60 fisher60 merged commit d3503bf into main Jun 18, 2024
3 checks passed
@fisher60 fisher60 deleted the feature/nuxt-login-page branch June 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants