Feature/466 running non swig v2 #652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
requested changes
Mar 23, 2024
There was a problem hiding this comment.
- edit commit comment on firsts commit
- add requested code comments and method descriptions
- add a unit test that checks if this work if we use this to connect with regular BSK messages. At least we are then checking the basic operation of this functionality. Add
unit test to src/architecture/messaging/_UnitTest - add release notes briefly describing what new functionality is added to
docs/source/Support/ReleaseNotes.rst - rebase on latest develop
| @@ -14,6 +14,8 @@ typedef struct {type}; | |||
| {type}_C_subscribe(self, source) | |||
| elif type(source) == {type}: | |||
| {type}_cpp_subscribe(self, source) | |||
| elif type(source) == int: | |||
There was a problem hiding this comment.
add a comment why you are checking if this is an int
| @@ -26,6 +28,8 @@ typedef struct {type}; | |||
| return ({type}_C_isSubscribedTo(self, source)) | |||
| elif type(source) == {type}: | |||
| return ({type}_cpp_isSubscribedTo(self, source)) | |||
| elif type(source) == int: | |||
There was a problem hiding this comment.
same here, add comment on why you are checking for int.
| @@ -107,6 +107,10 @@ void {type}_cpp_subscribe({type}_C *subscriber, void* source){{ | |||
| subscriber->headerPointer->isLinked = 1; // set output message as linked | |||
| }}; | |||
|
|
|||
| void {type}_addr_subscribe({type}_C *subscriber, uint64_t sourceAddr){{ | |||
There was a problem hiding this comment.
add a description of this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch makes it possible to use "foreign" modules inside Basilisk. In this case, foreign means that the module does not have to confirm to the Basilisk framework, particularly that SWIG is not required. It uses address access to be able to attach modules and messages to the Basilisk simulation context.
Verification
The verification for this update is basically that the modules do not break the existing use cases. However, going forward, non-SWIG modules (using pybind for example) could be added to Basilisk along with the associated dependencies.
Documentation
Undocumented. This is the deep dark heart of Basilisk.
Future work
I'm doing most of my research using pybind, and we can talk about adding those modules back into Basilisk using this mechanism if it makes sense.