Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial refiner support #12371

Merged
merged 9 commits into from
Aug 10, 2023
Merged

initial refiner support #12371

merged 9 commits into from
Aug 10, 2023

Conversation

AUTOMATIC1111
Copy link
Owner

@AUTOMATIC1111 AUTOMATIC1111 commented Aug 6, 2023

Description

  • two settings on Stable Diffusion page: Refiner checkpoint and Refiner switch at.
  • first lets you select a model.
  • second lets you select a ratio.
  • during sampling, when the number of steps goes above the amount specified by Refiner switch at setting, webui switches to a different model (Refiner checkpoint).
    • for example, if sampling with 20 steps and Refiner switch at = 0.25, the switch will happen after 5 sampling steps.
  • switch back to original checkpoint happens after you start generating the next picture (subject to change?)
  • tested with SD1.
  • tested with SDXL.
  • refining SD1 with SDXL or refining SDXL with SD1 with the way it's implemented is not a thing.
  • works with kdiffusion samplers.
  • works with compvis samplers! DDIM, PLMS, UniPC work.
  • not tested with medvram/lowvram
  • infotext support
  • in future i plan to integrate this in a nice way into main UI, for now you just gotta put it into quicksettings bar
  • other PR: Alternative refiner implementation #12377

firefox_dU7c2qS6mZ

00402-1

add proper support for recalculating conds in k-diffusion samplers
remove support for compvis samplers
@anae-git
Copy link

anae-git commented Aug 6, 2023

How do you disable it once set? Shouldn't there be a "None" at the top the list?

@AUTOMATIC1111
Copy link
Owner Author

disable by setting Refiner switch at to 1.

@catboxanon catboxanon added the sdxl Related to SDXL label Aug 7, 2023
@catboxanon catboxanon linked an issue Aug 7, 2023 that may be closed by this pull request
1 task
@AUTOMATIC1111 AUTOMATIC1111 merged commit 36762f0 into dev Aug 10, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the refiner branch August 10, 2023 14:05
@rltgjqmcpgjadyd
Copy link

I think it's better to have the refiner options in the Settings - SDXL tab. :)

@tmprabubiz
Copy link

Wow, this is ultimate. No need of installing any other webui for the sake of speed. But how to have these options in A1111. I can't find in settings. I don't know coding. May somebody guide to use this option..

@Aonodensetsu
Copy link

Aonodensetsu commented Aug 20, 2023

this is merged into dev, which means it's not on the mainline version yet, but will be coming soon

@w-e-w w-e-w mentioned this pull request Aug 24, 2023
@WaGi-Coding
Copy link

Imo it would be better if the switch at would work the other way round.

So if you set it to 0.1 on 30 steps, the last 3 steps will get refined. Or the last 6 with 0.2 and so on

@uomathguy
Copy link

This new refiner switch is nice! But why doesn't it have a "denoising strength" option for the refiner. That is a crucial element of using the refiner. Thanks!

@RamishRasool14
Copy link

Is this refiner available from the api docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdxl Related to SDXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: SDXL refiner support
9 participants