Refactor data loading workflow and support single evaluation mode #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sian-chen
commented
Apr 17, 2021
sian-chen
commented
- Change the data format
- Remove code for handling MIMIC
- Refactor data loading workflow to support single evaluation mode
sian-chen
changed the title
Eleven1Liu
requested changes
Apr 19, 2021
Eleven1Liu
reviewed
Apr 19, 2021
cjlin1
reviewed
Apr 20, 2021
cjlin1
reviewed
Apr 20, 2021
cjlin1
reviewed
Apr 20, 2021
cjlin1
reviewed
Apr 20, 2021
cjlin1
reviewed
Apr 20, 2021
cjlin1
reviewed
Apr 20, 2021
cjlin1
reviewed
Apr 20, 2021
cjlin1
reviewed
Apr 20, 2021
cjlin1
reviewed
Apr 21, 2021
data_utils.py
Outdated
| vocabs = Vocab(counter, specials=['<pad>', '<unk>'], min_freq=min_vocab_freq) | ||
|
|
||
| for data in dataset: | ||
| counter.update(set(data['text'])) |
There was a problem hiding this comment.
The original way of having "unique_tokens" may give better readability?
cjlin1
reviewed
Apr 21, 2021
cjlin1
reviewed
Apr 21, 2021
cjlin1
previously approved these changes
Apr 21, 2021
cjlin1
reviewed
Apr 21, 2021
Eleven1Liu
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.