P@k ranking

[Eleven1Liu]

Move all P@k, R@k into precision_recall_at_ks.

[sian-chen]

Suggested change

	for metric in self.config.monitor_metrics:
	result[metric] = scores[metric]
	result = {metric: scores[metric] for metric in self.config.monitor_metrics}

[cjlin1]

Looks good

…

On 2021-04-28 17:58, Eleven Liu wrote: @Eleven1Liu commented on this pull request. ------------------------- In metrics.py [1]: > + rank_mat = np.argsort(-y_pred_vals) + denom = y_true.sum(axis=1) + 1e-10 + scores = {} + for k in top_ks: + y_pred = np.take_along_axis(y_true, rank_mat[:,:k], axis=1) + scores[f'P@{k}'] = np.mean(np.sum(y_pred, axis=1) / k).item() # precision at k + scores[f'R@{k}'] = np.mean(y_pred.sum(axis=1) / denom).item() # recall at k y_pred_ranked_idx? -- You are receiving this because your review was requested. Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. [ { ***@***.***": "http:https://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#23 (comment)", "url": "#23 (comment)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ] Links: ------ [1] #23 (comment) [2] https://github.com/notifications/unsubscribe-auth/ABI3BHWZO37XX7IF6NS67ELTK7L35ANCNFSM43WG3OEA