Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove utils/log.py. #21

Merged
merged 5 commits into from
Apr 27, 2021
Merged

Remove utils/log.py. #21

merged 5 commits into from
Apr 27, 2021

Conversation

Eleven1Liu
Copy link
Collaborator

@Eleven1Liu Eleven1Liu commented Apr 26, 2021 •
edited
Loading

  • Remove logger.py, use logging instead.
  • Move utils.py out of utils.

@Eleven1Liu Eleven1Liu changed the title Remove logger.py. Remove utils/log.py. Apr 26, 2021
sian-chen
sian-chen suggested changes Apr 26, 2021
View reviewed changes
main.py Outdated Show resolved Hide resolved
data_utils.py Outdated Show resolved Hide resolved
cjlin1
cjlin1 reviewed Apr 26, 2021
View reviewed changes
model.py Outdated Show resolved Hide resolved
cjlin1
cjlin1 reviewed Apr 26, 2021
View reviewed changes
model.py Outdated Show resolved Hide resolved
cjlin1
cjlin1 reviewed Apr 26, 2021
View reviewed changes
utils.py Outdated Show resolved Hide resolved
@Eleven1Liu Eleven1Liu merged commit 84131d2 into master Apr 27, 2021
@Eleven1Liu Eleven1Liu deleted the remove_logger branch April 27, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sian-chen sian-chen sian-chen approved these changes

@henryyang42 henryyang42 Awaiting requested review from henryyang42 henryyang42 is a code owner

@cjlin1 cjlin1 Awaiting requested review from cjlin1 cjlin1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eleven1Liu @cjlin1 @sian-chen