Our first PR! #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryyang42
previously approved these changes
Apr 14, 2021
henryyang42
reviewed
Apr 14, 2021
| @log.enter('load_dataset') | ||
| def load_dataset(config): | ||
| """Preparing TextDataset from raw data.""" | ||
| data_dir = os.path.join(config['data_dir'], config['data_name']) |
There was a problem hiding this comment.
Unify all config['xxx'] syntax to config.xxx?
There was a problem hiding this comment.
Some hyperparameter search tools may require configs as a dictionary.
Correct me if I'm wrong.
henryyang42
reviewed
Apr 14, 2021
| parser.add_argument('--display_iter', type=int, default=100, help='Log state after every n epochs (default: %(default)s)') | ||
| parser.add_argument('--data_workers', type=int, default=1, help='Use multi-cpu core for data pre-processing (default: %(default)s)') | ||
| parser.add_argument('--eval', action='store_true', help='Only run evaluation on the test set (default: %(default)s)') | ||
| parser.add_argument('--load_checkpoint', help='The checkpoint to warm-up with (default: %(default)s)') |
There was a problem hiding this comment.
load_checkpoint is more like an action to me. Rename to, for example checkpoint_path, to match the description The checkpoint to warm-up with?
sian-chen
previously approved these changes
Apr 14, 2021
sian-chen
approved these changes
Apr 15, 2021
henryyang42
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first pull request.