Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GAMMA 20231208 #574

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Upgrade to GAMMA 20231208 #574

merged 4 commits into from
Jul 3, 2024

Conversation

forrestfwilliams
Copy link
Contributor

@forrestfwilliams forrestfwilliams commented Jul 2, 2024

Notable changes:

  • dem_gradient_vec: Calculate the gradient vector or the normal surface vector in ENU coordinates.
    The unit surface gradient vector lies on the surface and points in the direction of the steepest
    descent. The normal vector is perpendicular to the tangent plane.
  • phase_sim_orb, phase_sim: Improved accuracy in the calculation of the simulated phase. Default
    value for [ph_mode] has now been set to "1: subtract phase offset at scene center to improve
    precision"
  • geocoding.py: Now also supports using a constant height value instead of a DEM file.

I don't see any changes that should negatively impact our processing.

@forrestfwilliams forrestfwilliams requested a review from a team as a code owner July 2, 2024 19:54
Dockerfile Outdated Show resolved Hide resolved
@asjohnston-asf asjohnston-asf marked this pull request as draft July 2, 2024 23:32
@asjohnston-asf
Copy link
Member

Approved, but converting to a draft as a signal to avoid merging just yet. We have a handful of python upgrades currently in test. @jtherrmann and I are going to get those validated and released to production so we can have only the GAMMA upgrade in development during testing.

@forrestfwilliams
Copy link
Contributor Author

Sounds good @asjohnston-asf, I'll hold off until I hear from you all. FYI, golden tests passed!

@asjohnston-asf asjohnston-asf marked this pull request as ready for review July 3, 2024 17:19
@asjohnston-asf asjohnston-asf merged commit ac22ab4 into develop Jul 3, 2024
6 checks passed
@asjohnston-asf asjohnston-asf deleted the gamma_20231208 branch July 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants