Disabled lwip ethernet ipv6 multicast filter for STM boards #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
requested changes
Jun 9, 2017
| @@ -0,0 +1,48 @@ | |||
| #include "stm32f7xx_hal.h" | |||
There was a problem hiding this comment.
please add license to the new files
| .VLANTagIdentifier = 0x0 | ||
| }; | ||
|
|
||
| if (heth->Init.ChecksumMode == ETH_CHECKSUM_BY_HARDWARE) |
There was a problem hiding this comment.
please fix the formatting
if () {
//code here
} else {
}
|
How was this tested? Before the patch - any failures, after this one - what is fixed ? |
|
Verified with UBLOX EVK ODIN W2 board that ipv6 IP address allocation is working with this fix and mbed-os-example-application is able to connect to mbed device connector. Without this fix as in the original error multicast packets are not received by lwip stack and ipv6 address cannot be configured resulting -3010 error. |
0xc0170
approved these changes
Jun 9, 2017
|
Hi |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabled lwip ethernet ipv6 multicast filter for STM boards.
This is correction to #4432
Status
READY
Migrations
NO
Related PRs
None
Todos
Deploy notes
None
Steps to test or reproduce
None