Fix semaphore usage on lpc1768 emac #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semaphore xTXDCountSem had the count to match the number of resources available, but was being used as a binary semaphore in a loop to listen for events. This patch updates the logic to make use of the resource count. With RTX5 the OS traps with an error if the a semaphore is released more times than its count with an error similar to "Semaphore 10000e6c error -17". Because xTXDCountSem is being used as a binary semaphore it triggered this trap. With this patch the semaphore is no longer used as a binary semaphore and no longer traps.
1 task
0xc0170
approved these changes
Jun 6, 2017
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semaphore xTXDCountSem had the count to match the number of resources available, but was being used as a binary semaphore in a loop to listen for events. This patch updates the logic to make use of the resource count.
With RTX5 the OS traps with an error if the a semaphore is released more times than its count with an error similar to "Semaphore 10000e6c error -17". Because xTXDCountSem is being used as a binary semaphore it triggered this trap. With this patch the semaphore is no longer used as a binary semaphore and no longer traps.